Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6263: Add more Brave Search default regions. #6354

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Nov 8, 2022

Summary of Changes

This pull request fixes #6263

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Set your device's region to Brazil and Argentina.
Fresh install the app, verify that Brave Search is the default search engine.

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub requested a review from a team November 8, 2022 16:13
@iccub iccub added this to the 1.46 milestone Nov 8, 2022
@iccub iccub enabled auto-merge (squash) November 8, 2022 16:36
@iccub iccub merged commit 45e551a into development Nov 8, 2022
@iccub iccub deleted the bugfix/6263 branch November 8, 2022 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update search engine defaults for BR / AR
2 participants