Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6401: Add button accessibility traits to URL bar text field #6402

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Nov 15, 2022

Summary of Changes

This pull request fixes #6401

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team November 15, 2022 20:25
@iccub iccub added this to the 1.45.1 milestone Nov 15, 2022
@iccub
Copy link
Contributor

iccub commented Nov 15, 2022

Putting into 1.45.1 initially. Tomorrow we can decide whether this lands there or not

@iccub iccub merged commit e080ce0 into development Nov 16, 2022
@iccub iccub deleted the url-bar-accessibility branch November 16, 2022 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessing the URL field using VoiceOver is broken
2 participants