This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 444
Fix #6225: Ethereum Name Service (ENS) Navigation #7153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
nuo-xu
reviewed
Mar 28, 2023
...ces/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+ToolbarDelegate.swift
Outdated
Show resolved
Hide resolved
nuo-xu
reviewed
Mar 28, 2023
nuo-xu
force-pushed
the
wallet/ipfs-navigation
branch
from
March 28, 2023 15:19
577dd82
to
376308b
Compare
StephenHeaps
force-pushed
the
wallet/ens-navigation
branch
from
March 28, 2023 17:50
f9977d5
to
74a71b2
Compare
...ces/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+ToolbarDelegate.swift
Show resolved
Hide resolved
...ces/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+ToolbarDelegate.swift
Outdated
Show resolved
Hide resolved
...ces/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+ToolbarDelegate.swift
Show resolved
Hide resolved
...ces/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Web3NameService.swift
Show resolved
Hide resolved
...ntent/UserScripts/Scripts_Dynamic/ScriptHandlers/Internal/Web3NameServiceScriptHandler.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some minor comments, great test coverage and everything.
nuo-xu
approved these changes
Mar 30, 2023
Brandon-T
suggested changes
Mar 30, 2023
soner-yuksel
approved these changes
Apr 3, 2023
nuo-xu
force-pushed
the
wallet/ipfs-navigation
branch
from
April 3, 2023 18:43
376308b
to
340f7f9
Compare
Brandon-T
approved these changes
Apr 3, 2023
StephenHeaps
force-pushed
the
wallet/ens-navigation
branch
from
April 4, 2023 21:11
9cbb5a6
to
af0d9a5
Compare
nuo-xu
force-pushed
the
wallet/ipfs-navigation
branch
from
April 4, 2023 22:37
340f7f9
to
69a6553
Compare
StephenHeaps
force-pushed
the
wallet/ens-navigation
branch
from
April 5, 2023 01:03
af0d9a5
to
4b20b7f
Compare
@stoletheminerals @nuo-xu @Brandon-T @soner-yuksel I've added support for links tapped in a web view (main frame only), if you could please check out these changes 🙂. I've included a couple ENS/SNS links in this PR description that can be used to test. 8e0828f |
stoletheminerals
approved these changes
Apr 5, 2023
nuo-xu
force-pushed
the
wallet/ipfs-navigation
branch
from
April 6, 2023 15:34
1385625
to
8e81428
Compare
nuo-xu
approved these changes
Apr 6, 2023
…NameServiceScriptHandler` to be more generic. Support for SNS, ENS and ENS Offchain (and later Unstoppable Domains can re-use). Integrate initial support for ENS navigation via omnibar (supported until IPFS url received).
…o `BraveWallet` target
…elper`. Update `SettingsStoreTests` for testing `ensResolveMethod` in setup.
…user-entered url if user opens url bar on interstitial page.
… Update selected tab loading state when user presses stop.
…e optional, returning nil in private mode. Added unit test to verify.
…criptHandler`. Add helper function to initialize `DecentralizedDNSHelper` for BVC.
…entralizedDNSHelper`.
StephenHeaps
force-pushed
the
wallet/ens-navigation
branch
from
April 6, 2023 18:05
8e0828f
to
8155c17
Compare
Brandon-T
approved these changes
Apr 6, 2023
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2024
…ve/brave-ios#7153) * Add ENS Resolve Method preference to `Web3DomainSettingsView` * Refactor `SNSDomain.html`, `SNSDomain.css`, `SNSDomainHandler`, `Web3NameServiceScriptHandler` to be more generic. Support for SNS, ENS and ENS Offchain (and later Unstoppable Domains can re-use). Integrate initial support for ENS navigation via omnibar (supported until IPFS url received). * Add new `DecentralizedDNSHelper` to contain decentralized DNS logic to `BraveWallet` target * Add `DecentralizedDNSHelperTests` for unit testing `DecentralizedDNSHelper`. Update `SettingsStoreTests` for testing `ensResolveMethod` in setup. * Close keyboard / leave overlay mode when resolving decentralized DNS. Update selected tab loading state when user presses stop. * Use a single `Web3DomainHandler` by storing service id in url query. * Verify URL is not a bookmarklet / javascript before returning in `DecentralizedDNSHelper`. * Support decentralized DNS links when tapped on a website (main-frame only).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
BraveWallet
target with a newDecentralizedDNSHelper
class (w/ unit tests).BraveWallet
target too. This requires some refactoring of current logic (need to extractTabContentScript
/TabContentScriptLoader
/InternalSchemeResponse
out of Client and into a shared target).This pull request fixes #6225
Submitter Checklist:
NSLocalizableString()
Test Plan:
Resolve Ethereum Name Service (ENS) Domain Names
toAsk
Allow ENS Offchain Lookup
toAsk
Resolve IPFS Resources
to ask (optional); ENS will always load to an IPFS url; must be eitherAsk
orEnabled
offchainexample.eth
/ http://offchainexample.ethResolve Ethereum Name Service (ENS) Domain Names
is set toDisabled
Resolve Ethereum Name Service (ENS) Domain Names
back toAsk
offchainexample.eth
/ http://offchainexample.ethProceed using Infura server
Disabled
Allow ENS Offchain Lookup
is set toDisabled
Allow ENS Offchain Lookup
back toAsk
offchainexample.eth
/ http://offchainexample.ethProceed with offchain lookup
SNS: http://onybose.sol
ENS: http://offchainexample.eth
Screenshots:
6225.mp4
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement