Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7667: Fix Long-press not detecting video elements of zero size #7679

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

Brandon-T
Copy link
Collaborator

Summary of Changes

  • Allow Long-Press on video and audio elements that have zero size to be detected by a long-press on the page itself.

This pull request fixes #7667

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T added this to the 1.53 milestone Jul 4, 2023
@Brandon-T Brandon-T requested a review from a team as a code owner July 4, 2023 17:15
@Brandon-T Brandon-T self-assigned this Jul 4, 2023
@iccub iccub merged commit 29c4fb0 into development Jul 6, 2023
7 checks passed
@iccub iccub deleted the bugfix/PlaylistLongPressAudio branch July 6, 2023 14:50
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
… of zero size (brave/brave-ios#7679)

Fix long-press not detecting video elements of zero size.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Playlist] Not able to add an audio file to the Playlist by tapping and holding on a file
3 participants