Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ref #4879: VPN churn improvements - VerifyReceiptData fields with isBillingRetry #7803

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Jul 28, 2023

Summary of Changes

Second part Pr for VPN Churn improvement. After #7670 added Pop-over types and new style of displaying the pop-overs.

This PR is adding fixes for proper priority for Callouts and method for displaying update billing pop over.

In addition main part is implementation of verifyReceiptData function which is right now only used in AppLaunch which can retrieve all details of receipt.

The tests are added for receipt field different variation.

There will be a 3 rd Pr after this to combine menu changes and popover UX depending on this PR. But this Pr can be merged when review is finished and application works as expected with the change of verifyReceipt data functions

This pull request fixes #4879

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

N/A

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.57 milestone Jul 28, 2023
@soner-yuksel soner-yuksel requested a review from iccub July 28, 2023 18:58
@soner-yuksel soner-yuksel requested a review from a team as a code owner July 28, 2023 18:58
@soner-yuksel soner-yuksel self-assigned this Jul 28, 2023
@soner-yuksel soner-yuksel changed the title Ref #4879: VPN churn improvements - Popover Types Ref #4879: VPN churn improvements - VerifyReceiptData fields with isBillingRetry Jul 28, 2023
@soner-yuksel soner-yuksel requested a review from iccub August 2, 2023 18:41
@soner-yuksel soner-yuksel merged commit d0e8bbe into development Aug 2, 2023
7 checks passed
@soner-yuksel soner-yuksel deleted the enhancement/vpn-billing-update branch August 2, 2023 21:01
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPN Billing Retry Changes
2 participants