Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7896: Whitelist Twitter/X.com for Playlist URL Bar Button #7913

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

Brandon-T
Copy link
Collaborator

Summary of Changes

  • Playlist URL Bar Button will now show up on X.com or Twitter.com

This pull request fixes #7896

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Visit a twitter page that has video
  • The URL bar button should show to add the video to playlist.

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T added this to the 1.58 milestone Aug 22, 2023
@Brandon-T Brandon-T self-assigned this Aug 22, 2023
@Brandon-T Brandon-T requested a review from a team as a code owner August 22, 2023 14:05
@Brandon-T Brandon-T merged commit 835d053 into development Aug 22, 2023
@Brandon-T Brandon-T deleted the feature/Twitter-Playlist branch August 22, 2023 15:22
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitelist twitter on Playlist
2 participants