Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6577: Hide Active NTP when backgrounding the app in private mode #7937

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Aug 23, 2023

Summary of Changes

This pull request fixes #6577

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Enter Private Mode and make a new tab
  • Verify background the app will hide the new tab page

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team as a code owner August 23, 2023 20:51
@kylehickinson kylehickinson added this to the 1.58 milestone Aug 23, 2023
@kylehickinson kylehickinson enabled auto-merge (squash) August 23, 2023 20:52
@kylehickinson kylehickinson merged commit 68f8a13 into development Aug 23, 2023
7 checks passed
@kylehickinson kylehickinson deleted the private-mode-bg-ntp branch August 23, 2023 21:29
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show blank page instead of NTP/site preview when switching apps
2 participants