Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7961: Tokens on Testnets still shown in Edit Visible Assets Screen when testnets are filtered out #7972

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Fix #7961: Tokens on Testnets still shown in Edit Visible Assets Screen when testnets are filtered out #7972

merged 5 commits into from
Aug 28, 2023

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Aug 28, 2023

Summary of Changes

This pull request fixes #7961

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Please refer to the issue

Screenshots:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-28.at.10.10.02.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu added this to the 1.57 milestone Aug 28, 2023
@nuo-xu nuo-xu self-assigned this Aug 28, 2023
@nuo-xu nuo-xu requested a review from a team as a code owner August 28, 2023 14:11
@nuo-xu nuo-xu enabled auto-merge (squash) August 28, 2023 18:13
@nuo-xu nuo-xu merged commit 96a6ef8 into development Aug 28, 2023
7 checks passed
@nuo-xu nuo-xu deleted the bugfix/test-network-tokens branch August 28, 2023 18:35
nuo-xu added a commit that referenced this pull request Aug 28, 2023
@nuo-xu
Fix #7961: Tokens on Testnets still shown in Edit Visible Assets Scre…
c616e68 
…en when testnets are filtered out (#7972)
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@nuo-xu
Fix brave/brave-ios#7961: Tokens on Testnets still shown in Edit Visi…
b1ca89e 
…ble Assets Screen when testnets are filtered out (brave/brave-ios#7972)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenHeaps StephenHeaps StephenHeaps approved these changes

Assignees

@nuo-xu nuo-xu

Labels
None yet
Projects
None yet
Milestone
1.57
Development

Successfully merging this pull request may close these issues.

Test network tokens are still shown in edit visible tokens when filtering to a specific network
2 participants
@nuo-xu @StephenHeaps