Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8035: Certain schemas not going to the app store #8025

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

ElonPark
Copy link
Contributor

@ElonPark ElonPark commented Sep 5, 2023

Summary of Changes

This pull request fixes #8035

Same bug, but on Brave it leads to search

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Enter the URL itms-apps://apps.apple.com/app/pulse-secure/id945832041?l=en in the address bar
  2. Should present alert go to the app store

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@ElonPark ElonPark requested a review from a team as a code owner September 5, 2023 04:49
@iccub iccub changed the title fixed certain schemas not going to the app store Fix #8035: Certain schemas not going to the app store Sep 6, 2023
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@ElonPark
Copy link
Contributor Author

ElonPark commented Sep 8, 2023

thank you :)

I also add AppStore shortened URL host
1b4030f

@ElonPark
Copy link
Contributor Author

ElonPark commented Sep 8, 2023

Refactoring 3f5ea7b

스크린샷 2023-09-08 오후 12 35 21

@iccub iccub added this to the 1.58 milestone Sep 8, 2023
@iccub iccub merged commit 1629ef6 into brave:development Sep 8, 2023
8 checks passed
@iccub
Copy link
Contributor

iccub commented Sep 8, 2023

Very clean PR. Thank you

@ElonPark ElonPark deleted the improve-store-url-check-logic branch September 14, 2023 00:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

itms-apps scheme is not working
2 participants