Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7851: Tab selection for TabsBar interface is done after active website is loaded #8032

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Sep 5, 2023

Summary of Changes

This pull request fixes #7851

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Enable Tabs Bar

  • Load multiple tabs (+10 tabs etc)

  • Remove the app from background if it is active

  • Launch fresh

  • Observe the active tab is selected after website is loaded

Screenshots:

RPReplay_Final1693949329.MOV

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel requested a review from a team as a code owner September 5, 2023 21:33
@soner-yuksel soner-yuksel self-assigned this Sep 5, 2023
@soner-yuksel soner-yuksel added this to the 1.58 milestone Sep 6, 2023
@soner-yuksel soner-yuksel merged commit 041dc88 into development Sep 6, 2023
7 checks passed
@soner-yuksel soner-yuksel deleted the fix/tabs-scroll-bar branch September 6, 2023 13:44
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab selection for TabsBar interface is done after active website is loaded
2 participants