Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8166: Wallet Tab Bar #8287

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Fix #8166: Wallet Tab Bar #8287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4a1310
Use TabView for wallet instead of page controller.
StephenHeaps Oct 18, 2023
497b649
Navigation structure updates; each tab has it’s own `NavigationView`.…
StephenHeaps Oct 18, 2023
341fede
Copy update
StephenHeaps Oct 19, 2023
3d78696
iOS 15 iPad fix
StephenHeaps Oct 19, 2023
c30e143
Fix shimmer causing navigation items to animate
StephenHeaps Oct 20, 2023
492443c
Address PR comments; unneeded imports & opaque tab bar.
StephenHeaps Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions Sources/BraveUI/SwiftUI/Shimmer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,10 @@ private struct ShimmerViewModifier: ViewModifier {
endPoint: points.1
)
.onAppear {
if #available(iOS 16, *) {
DispatchQueue.main.async { [self] in // Need this due to a SwiftUI bug…
withAnimation(animation) {
points = (.trailing, UnitPoint(x: 2, y: 0.5))
}
} else {
DispatchQueue.main.async { [self] in // Need this due to a SwiftUI bug…
withAnimation(animation) {
points = (.trailing, UnitPoint(x: 2, y: 0.5))
}
}
}
}
}
Expand Down
263 changes: 0 additions & 263 deletions Sources/BraveWallet/Crypto/CryptoPagesView.swift
View file
Open in desktop

This file was deleted.

Loading