Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8286: Update "Edit bookmark" to "Edit favorite" when long pressing a favorite #8303

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Fix #8286: Update "Edit bookmark" to "Edit favorite" when long pressing a favorite #8303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
039a57c
Merge pull request #1 from brave/development
bo1ta Oct 21, 2023
2193a5e
Fix #8286: Update 'Edit bookmark' to 'Edit favorite'
bo1ta Oct 22, 2023
d7a23dd
[fix-edit-favorite-title] Update alert title
bo1ta Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Brave/Frontend/Browser/BrowserViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3063,7 +3063,7 @@ extension BrowserViewController: NewTabPageDelegate {
let editPopup =
UIAlertController
.userTextInputAlert(
title: Strings.editBookmark,
title: Strings.editFavorite,
message: urlString,
startingText: title, startingText2: favorite.url,
placeholder2: urlString,
Expand Down
2 changes: 1 addition & 1 deletion Sources/Brave/Frontend/Browser/Favorites/FavoritesViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ extension FavoritesViewController: UICollectionViewDelegateFlowLayout {
self.action(bookmark, .opened(inNewTab: true, switchingToPrivateMode: false))
})
let edit = UIAction(
title: Strings.editBookmark,
title: Strings.editFavorite,
handler: UIAction.deferredActionHandler { _ in
self.action(bookmark, .edited)
})
Expand Down
2 changes: 1 addition & 1 deletion Sources/Brave/Frontend/Browser/New Tab Page/Sections/FavoritesSectionProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class FavoritesSectionProvider: NSObject, NTPObservableSectionProvider {
self.action(favourite, .opened(inNewTab: true, switchingToPrivateMode: false))
})
let edit = UIAction(
title: Strings.editBookmark,
title: Strings.editFavorite,
handler: UIAction.deferredActionHandler { _ in
self.action(favourite, .edited)
})
Expand Down