[Uplift] Impose the max engines limitation on content blockers (uplift to 1.58.1) #8336

cuba · 2023-10-30T18:47:07Z

Summary of Changes

No bugfix
Original issue: #8294

Unit Tests are updated to cover new or changed functionality
User-facing strings use NSLocalizableString()
New or updated UI has been tested across:
- Light & dark mode
- Different size classes (iPhone, landscape, iPad)
- Different dynamic type sizes

See issue above for STR

Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
Necessary security reviews have taken place.
Adequate unit test coverage exists to prevent regressions.
Adequate test plan exists for QA to validate (if applicable).
Issue and pull request is assigned to a milestone (should happen at merge time).

Compile max content blockers

cuba added 2 commits October 30, 2023 12:30

Fix #8292: Change the minimum number of engines available (#8288)

8dbf584

Fix #8294: Compile only the needed content blockers eagerly (#8295)

6b9c911

Compile max content blockers

cuba requested a review from a team as a code owner October 30, 2023 18:47

iccub approved these changes Oct 30, 2023

View reviewed changes

iccub added this to the 1.58.1 milestone Oct 30, 2023

iccub added the QA/No label Oct 30, 2023

iccub merged commit 7a6dae7 into hotfix1.58.1 Oct 30, 2023
4 of 5 checks passed

iccub deleted the js/uplift-1.58.1 branch October 30, 2023 19:27

iccub modified the milestones: 1.58.1, 1.58.2 Nov 3, 2023

kjozwiak modified the milestones: 1.58.2, 1.58.1 Nov 3, 2023