Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8515: Update SNS interstitial page copy and help page link #8553

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix #8515: Update SNS interstitial page copy and help page link #8553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb23eb7
SNS copy update
StephenHeaps Dec 11, 2023
f52c72d
update sns brave wiki link
nuo-xu Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Sources/Brave/Frontend/Browser/Handlers/Web3DomainHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,10 @@ extension Web3Service {
var errorDescription: String {
switch self {
case .solana:
let termsOfUseUrl = WalletConstants.snsTermsOfUseURL.absoluteString
let privacyPolicyUrl = WalletConstants.snsPrivacyPolicyURL.absoluteString
let braveWikiUrl = WalletConstants.snsBraveWikiURL.absoluteString
return String.localizedStringWithFormat(
Strings.Wallet.snsDomainInterstitialPageDescription,
termsOfUseUrl,
Strings.Wallet.web3DomainInterstitialPageTAndU,
privacyPolicyUrl,
Strings.Wallet.web3DomainInterstitialPagePrivacyPolicy)
braveWikiUrl)
case .ethereum:
let termsOfUseUrl = WalletConstants.ensTermsOfUseURL.absoluteString
let privacyPolicyUrl = WalletConstants.ensPrivacyPolicyURL.absoluteString
Expand Down
8 changes: 3 additions & 5 deletions Sources/BraveWallet/WalletConstants.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,9 @@ public struct WalletConstants {
/// The url to Brave Help Center for Wallet.
static let braveWalletSupportURL = URL(string: "https://support.brave.com/hc/en-us/categories/360001059151-Brave-Wallet")!

/// Terms of Use for Solana Name Service (SNS)
public static let snsTermsOfUseURL: URL = URL(string: "https://syndica.io/terms-and-conditions/")!

/// Privacy Policy for Solana Name Service (SNS)
public static let snsPrivacyPolicyURL: URL = URL(string: "https://syndica.io/privacy-policy/")!
// TODO: update wiki link
/// Brave Wiki page for Solana Name Service (SNS)
public static let snsBraveWikiURL: URL = URL(string: "https://github.com/brave/brave-browser/wiki/Resolve-Methods-for-Solana-Name-Service")!

/// Terms of Use for Ethereum Name Service (ENS)
public static let ensTermsOfUseURL: URL = URL(string: "https://consensys.net/terms-of-use/")!
Expand Down
10 changes: 5 additions & 5 deletions Sources/BraveWallet/WalletStrings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4137,29 +4137,29 @@ extension Strings {
"wallet.snsDomainInterstitialPageTitle",
tableName: "BraveWallet",
bundle: .module,
value: "Enable support of Solana Name Service (SNS) in Brave?",
value: "Enable Support of Solana Name Service (SNS) in Brave?",
comment: "Title displayed when users chose Brave to ask them if they want the SNS to be resolved every time they enter one."
)
public static let snsDomainInterstitialPageDescription = NSLocalizedString(
"wallet.snsDomainInterstitialPageDescription",
tableName: "BraveWallet",
bundle: .module,
value: "Brave will be using Syndica to resolve .sol domain names. Brave hides your IP address. If you enable this, Syndica will see that someone is trying to visit these .sol domains but nothing else. See Syndica's <a href=%@>%@</a> and <a href=%@>%@</a>.",
comment: "Description displayed when users chose Brave to ask them if they want the SNS to be resolved every time they enter one. The first '%@' will be replaced with a link to Syndica's terms of use page. The second '%@' will be replaced with the value of 'snsDomainInterstitialPageTAndU'. The third '%@' will be replaced with a link to Syndica's privacy policy page. The last '%@' will be replaced with the value of 'snsDomainInterstitialPagePrivacyPolicy'."
value: "Brave will use a third-party to resolve .sol domain names. Brave hides your IP address. If you enable this, the third-party will see that someone is trying to visit these .sol domains, but nothing else. For more information about which third-parties we use and their privacy policies, please see our <a href=%@>help page</a>.",
comment: "Description displayed when users chose Brave to ask them if they want the SNS to be resolved every time they enter one. The first '%@' will be replaced with a link to Brave's wiki page which will link to the providersterms of use page and privacy policy page. The last '%@' will be replaced with the value of 'snsDomainInterstitialPagePrivacyPolicy'."
)
public static let snsDomainInterstitialPageButtonProceed = NSLocalizedString(
"wallet.snsDomainInterstitialPageButtonProceed",
tableName: "BraveWallet",
bundle: .module,
value: "Proceed using Syndica server",
value: "Proceed using an SNS server",
comment: "Title on the button that users can click to enable Brave to resolve the SNS domain they entered."
)
// ENS
public static let ensDomainInterstitialPageTitle = NSLocalizedString(
"wallet.ensDomainInterstitialPageTitle",
tableName: "BraveWallet",
bundle: .module,
value: "Enable support of Ethereum Name Service (ENS) in Brave?",
value: "Enable Support of Ethereum Name Service (ENS) in Brave?",
comment: "Title displayed when users chose Brave to ask them if they want the ENS domain to be resolved every time they enter one."
)
public static let ensDomainInterstitialPageDescription = NSLocalizedString(
Expand Down