This repository has been archived by the owner on May 13, 2024. It is now read-only.
update Sync spec and fix several brave-core issues #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
force-pushed
the
sync-spec
branch
2 times, most recently
from
dcf5729
to
1bc399b
Compare
cezaraugusto
force-pushed
the
sync-spec
branch
from
1bc399b
to
81add01
Compare
- updated illustrations from png to svg - updated a few small locale strings - removed clipboard from target computer code entry
rossmoody
approved these changes
Jan 3, 2019
cezaraugusto
added a commit
that referenced
this pull request
Jan 4, 2019
update Sync spec and fix several brave-core issues
cezaraugusto
added a commit
that referenced
this pull request
Jan 4, 2019
This reverts commit db6f6f9.
cezaraugusto
added a commit
that referenced
this pull request
Jan 4, 2019
update Sync spec and fix several brave-core issues
cezaraugusto
added a commit
that referenced
this pull request
Jan 4, 2019
update Sync spec and fix several brave-core issues
cezaraugusto
added a commit
that referenced
this pull request
Jan 4, 2019
This reverts commit 5ea3cdd.
cezaraugusto
added a commit
that referenced
this pull request
Jan 4, 2019
update Sync spec and fix several brave-core issues
cezaraugusto
added a commit
that referenced
this pull request
Jan 7, 2019
Merge pull request #332 from brave/sync-spec
cezaraugusto
added a commit
that referenced
this pull request
Jan 7, 2019
Merge pull request #332 from brave/sync-spec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR makes change in some Sync components and in the
AlertBoxandModalcomponents. None of them are breaking and the removal of outdated Sync components will be addressed once this PR tweaks land in brave-core to avoid breaking changes.Test plan
Mostly check that Sync components match the design at https://share.goabstract.com/ef5f3ea9-3aec-472e-81d0-1ad72d2a70e5.
Link / storybook path to visual changes
Integration
Does this contain changes to src/components or src/
Does this contain changes to src/features for brave-core?