Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Adds enabled AC to the panel #359

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Adds enabled AC to the panel #359

merged 1 commit into from
Jan 31, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 31, 2019 •
edited
Loading

Changes

Related to brave/brave-browser#3103

Test plan

Go into Feature Components -> Rewards -> Wallet -> Desktop -> Panel
Toggle AC enabled? knob and make sure that AC stuff is hidden

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)

  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@NejcZdovc NejcZdovc self-assigned this Jan 31, 2019
@NejcZdovc NejcZdovc force-pushed the panel-ac branch 2 times, most recently from db928e1 to 7750af7 Compare January 31, 2019 06:32
@NejcZdovc NejcZdovc mentioned this pull request Jan 31, 2019
Merged
18 tasks
@NejcZdovc NejcZdovc requested a review from ryanml January 31, 2019 06:42
ryanml
ryanml approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NejcZdovc NejcZdovc merged commit 1f9f90d into master Jan 31, 2019
@NejcZdovc NejcZdovc deleted the panel-ac branch January 31, 2019 08:01
NejcZdovc added a commit that referenced this pull request Jan 31, 2019
@NejcZdovc
Merge pull request #359 from brave/panel-ac
844d6b0 
Adds enabled AC to the panel
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanml ryanml ryanml approved these changes

@jasonrsadler jasonrsadler Awaiting requested review from jasonrsadler

Assignees

@NejcZdovc NejcZdovc

Labels
rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @ryanml