Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas related kill switches #1067

Merged
merged 1 commit into from
May 21, 2024
Merged

Canvas related kill switches #1067

merged 1 commit into from
May 21, 2024

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented May 21, 2024

For #1060
PR to production: #1068

Both features need to be disabled.

We use max_version: 125.* because cr126 got the fix in the code, so we don't need to cover it.
min_version isn't set because Finch config disables:

  1. EvictionUnlocksResources for >= cr124
    (for <= cr123 it's disabled in the code )
  2. Canvas2DHibernation for all the revisions.

P.S. Chrome has 2 separate studies, but it looks less reliable.

Steps to reproduce: https://issues.chromium.org/u/0/issues/341105739

@atuchin-m atuchin-m self-assigned this May 21, 2024
@atuchin-m atuchin-m requested a review from a team as a code owner May 21, 2024 10:49
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into main so we can get #1068 merged into production.

@kjozwiak kjozwiak merged commit 3ea451b into main May 21, 2024
6 checks passed
@kjozwiak kjozwiak deleted the canvas-kill-switches branch May 21, 2024 16:56
@kjozwiak
Copy link
Member

kjozwiak commented May 21, 2024

Win 11 x64 verifications

Nightly - CanvasKillSwitches:Disabled_EmergencyKillSwitch

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.68.25 Chromium: 125.0.6422.60 (Official Build) nightly (64-bit)
-- | --
Revision | aa179dbee72ac0ca0412be64803ecbe931bb3a9e
OS | Windows 11 Version 23H2 (Build 22631.3593)
  • launched 1.68.25 Chromium: 125.0.6422.60 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that CanvasKillSwitches:Disabled_EmergencyKillSwitch wasn't being displayed under brave://version
  • opened ~5 tabs and then visited https://www.w3schools.com/html/tryit.asp?filename=tryhtml5_canvas_tut_path2
    • notice that the canvas is completely blank (should be displaying a circle)
  • Restarted using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that CanvasKillSwitches:Disabled_EmergencyKillSwitch was being displayed under brave://version
  • ensured that the canvas is being displayed/visible
Broken Fixed
Nightly1 nightly3
nightly2 nightly4

Release - CanvasKillSwitches:Disabled_EmergencyKillSwitch

Brave | 1.66.110 Chromium: 125.0.6422.60 (Official Build) (64-bit)
-- | --
Revision | de593d76e2ca4d02faa85bf1ca27bcf3ee46793c
OS | Windows 11 Version 23H2 (Build 22631.3593)
  • launched 1.66.110 Chromium: 125.0.6422.60 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that CanvasKillSwitches:Disabled_EmergencyKillSwitch wasn't being displayed under brave://version
  • opened ~5 tabs and then visited https://www.w3schools.com/html/tryit.asp?filename=tryhtml5_canvas_tut_path2
    • notice that the canvas is completely blank (should be displaying a circle)
  • Restarted using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that CanvasKillSwitches:Disabled_EmergencyKillSwitch was being displayed under brave://version
  • ensured that the canvas is being displayed/visible
Broken Fixed
release1 release3
release2 release4

@kjozwiak
Copy link
Member

kjozwiak commented May 22, 2024

Pixel 6 running Android 14 verifications

Release - CanvasKillSwitches:Disabled_EmergencyKillSwitch

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.66.110 Chromium: 125.0.6422.60 (Official Build) (64-bit)
--- | ---
Revision | de593d76e2ca4d02faa85bf1ca27bcf3ee46793c
OS | Android 14; Build/AP21.240305.005; 34; REL
  • launched 1.66.110 Chromium: 125.0.6422.60 and ensured that Brave was pointing to https://variations.brave.com/seed
  • ensured that CanvasKillSwitches:Disabled_EmergencyKillSwitch wasn't being displayed under brave://version
  • opened ~5 tabs and then visited https://www.w3schools.com/html/tryit.asp?filename=tryhtml5_canvas_tut_path2
    • notice that the canvas is completely blank (should be displaying a circle)
  • uninstalled/re-installed Brave but ensured that it's pointing to https://variations.bravesoftware.com/seed (staging)
  • ensured that CanvasKillSwitches:Disabled_EmergencyKillSwitch was being displayed under brave://version
  • ensured that the canvas is being displayed/visible (using the same STR/Cases mentioned above)
Broken Fixed
Screenshot_20240521-180907 Screenshot_20240522-005747
Screenshot_20240522-005253 Screenshot_20240522-010254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants