-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvas related kill switches #1067
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atuchin-m
force-pushed
the
canvas-kill-switches
branch
from
May 21, 2024 10:55
67d9e4a
to
f207bb5
Compare
goodov
approved these changes
May 21, 2024
kjozwiak
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Merging into main
so we can get #1068 merged into production
.
|
Broken |
Fixed |
---|---|
Release
- CanvasKillSwitches:Disabled_EmergencyKillSwitch
Brave | 1.66.110 Chromium: 125.0.6422.60 (Official Build) (64-bit)
-- | --
Revision | de593d76e2ca4d02faa85bf1ca27bcf3ee46793c
OS | Windows 11 Version 23H2 (Build 22631.3593)
- launched
1.66.110 Chromium: 125.0.6422.60
usingbrave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
CanvasKillSwitches:Disabled_EmergencyKillSwitch
wasn't being displayed underbrave://version
- opened
~5 tabs
and then visited https://www.w3schools.com/html/tryit.asp?filename=tryhtml5_canvas_tut_path2- notice that the canvas is completely blank (should be displaying a circle)
- Restarted using
brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
CanvasKillSwitches:Disabled_EmergencyKillSwitch
was being displayed underbrave://version
- ensured that the canvas is being displayed/visible
Broken |
Fixed |
---|---|
|
Broken |
Fixed |
---|---|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1060
PR to production: #1068
Both features need to be disabled.
We use
max_version: 125.*
because cr126 got the fix in the code, so we don't need to cover it.min_version
isn't set because Finch config disables:EvictionUnlocksResources
for >= cr124(for <= cr123 it's disabled in the code )
Canvas2DHibernation
for all the revisions.P.S. Chrome has 2 separate studies, but it looks less reliable.
Steps to reproduce: https://issues.chromium.org/u/0/issues/341105739