Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating most performant test leg of ad model predictor recency study #1113

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ptjames
Copy link
Contributor

@ptjames ptjames commented Jul 8, 2024

Updating most performant test leg of ad model predictor recency study to 100% until brave-core changes reach production.

Issue: #1114
Changes become permanent in brave-core via this PR: brave/brave-core#24253

@ptjames ptjames requested a review from tmancey July 8, 2024 14:18
seed/seed.json Outdated Show resolved Hide resolved
@ptjames ptjames requested a review from aseren July 8, 2024 15:39
@ptjames ptjames marked this pull request as ready for review July 8, 2024 15:39
@ptjames ptjames requested a review from a team as a code owner July 8, 2024 15:39
@tmancey tmancey self-requested a review July 8, 2024 15:45
Copy link
Contributor

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++ (please squash commits)

… to 100% until brave-core changes reach production

updating max version
@ptjames ptjames force-pushed the ad_model_recency_study_completed branch from 535d3e7 to 4d06207 Compare July 8, 2024 15:49
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into main (staging) before we uplift/merge #1115 into production.

@kjozwiak kjozwiak merged commit c8d8b3e into main Jul 9, 2024
6 checks passed
@kjozwiak kjozwiak deleted the ad_model_recency_study_completed branch July 9, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants