Switch perf to studies #1243
Merged
Switch perf to studies #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodov
approved these changes
Oct 28, 2024
atuchin-m
force-pushed
the
switch-perf-to-studies
branch
from
30a492b
to
1a5e330
Compare
goodov
reviewed
Oct 28, 2024
| @@ -23,9 +24,6 @@ jobs: | |||
| - name: Install requirements | |||
| run: pip install -r seed/requirements.txt | |||
|
|
|||
| - name: Serialize seed | |||
| run: python seed/serialize.py seed/seed.json | |||
|
|
|||
| - name: Generate testing_fieldtrials.json (HEAD) | |||
There was a problem hiding this comment.
let's rename this workflow file to be something like test-testing-fieldtrials-gen.yml, and also rename name: Test Python Generator to a better suitable name.
| @@ -4,6 +4,7 @@ on: | |||
| pull_request: | |||
| paths: | |||
| - 'seed/**' | |||
| - 'studies/**' | |||
goodov
approved these changes
Oct 28, 2024
goodov
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR:
seed.jsontostudies/seed.json