Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Rewards 3.0 on Release (25%) #1302

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

zenparsing
Copy link
Contributor

This change enables Rewards 3.0 on Release at 25%.

@zenparsing zenparsing requested a review from a team as a code owner February 4, 2025 20:57
Copy link
Contributor

github-actions bot commented Feb 4, 2025

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1302.
    Android: Set the command line to --variations-pr=1302 in debug menu, restart the browser.
    iOS: Set Variations PR to 1302 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1302@d1b141d77c26b450d8a57800da9e1845e0feb5e9
Uploaded Tue, 04 Feb 2025 20:58:54 GMT
PR commit 424b96b
Base commit 5101c72
Merge commit d1b141d
Serial number 26a62cffa916ff659c59eb158005cd9f

@kjozwiak
Copy link
Member

kjozwiak commented Feb 5, 2025

Windows x64 verification(s):

Release - BraveRewardsNewRewardsUIStudy:Enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.75.174 Chromium: 133.0.6943.54 (Official Build) (64-bit)
-- | --
Revision | 097c41c8fd0150d3cc2f6e6500ed21ed26c430b8
OS | Windows 11 Version 24H2 (Build 26100.2894)
JavaScript | V8 13.3.415.19
  • launched/re-launched 1.75.174 Chromium: 133.0.6943.54 using brave.exe --enable-logging=stderr --variations-pr=1302
  • ensured that pull/1302@d1b141d77c26b450d8a57800da9e1845e0feb5e9 via brave://version under Active variations
  • ensured that BraveRewardsNewRewardsUIStudy:Enabled via brave://version
  • ensured that the new Rewards 3.0 panel is being used when clicking on the BAT icon
  • ensured that the new UI/Design is being used/visible via brave://rewards
Example Example Example Example Example
image image image image image

Release - BraveRewardsNewRewardsUIStudy:Default

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.75.174 Chromium: 133.0.6943.54 (Official Build) (64-bit)
-- | --
Revision | 097c41c8fd0150d3cc2f6e6500ed21ed26c430b8
OS | Windows 11 Version 24H2 (Build 26100.2894)
JavaScript | V8 13.3.415.19
  • launched/re-launched 1.75.174 Chromium: 133.0.6943.54 using brave.exe --enable-logging=stderr --variations-pr=1302
  • ensured that pull/1302@d1b141d77c26b450d8a57800da9e1845e0feb5e9 via brave://version under Active variations
  • ensured that BraveRewardsNewRewardsUIStudy:Default via brave://version
  • ensured that the current Rewards design is being used when clicking on the rewards panel and brave://rewards
Example Example Example Example
image image image image

Release - BraveRewardsNewRewardsUIStudy (not applied due to min_version)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.75.171 Chromium: 132.0.6834.160 (Official Build) (64-bit)
-- | --
Revision | d4d146998a285171ea57c3b75c52c7819901571a
OS | Windows 11 Version 24H2 (Build 26100.2894)
  • launched/re-launched 1.75.171 Chromium: 132.0.6834.160 using brave.exe --enable-logging=stderr --variations-pr=1302
  • ensured that pull/1302@d1b141d77c26b450d8a57800da9e1845e0feb5e9 via brave://version under Active variations
  • ensured that BraveRewardsNewRewardsUIStudy is not being used/applied under brave://version
  • ensured that the current Rewards design is being used when clicking on the rewards panel and brave://rewards
Example Example Example
image image image

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 1673a25 Feb 6, 2025
6 checks passed
@kjozwiak kjozwiak deleted the ksmith-rewards-3-release branch February 6, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants