Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable debounce at 100% on all channels #195

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Conversation

pilgrim-brave
Copy link
Contributor

No description provided.

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner January 6, 2022 21:59
@pilgrim-brave pilgrim-brave self-assigned this Jan 6, 2022
seed/seed.json Outdated Show resolved Hide resolved
@kjozwiak
Copy link
Member

kjozwiak commented Jan 17, 2022

Master/Nightly

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.36.41 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
-- | --
Revision | adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS | Windows 11 Version 21H2 (Build 22000.434)

Enabled

Launched Brave using brave.exe --enable-logging=stderr --v=1 --variations-server-url=https://variations.bravesoftware.com/seed and verified the following:

  • ensured that Brave Local Data Updater > than Brave Local Data Updater - Version: 1.0.45 which was the version that wasn't working when initially running through the above. Most recent version appears to be Brave Local Data Updater - Version: 1.0.49 which has the latest debounce list
  • ensured that BraveDebounceStudy:Enabled under brave://version (after restarting twice due to a Griffin limitation)

Went through the cases under https://dev-pages.brave.software/navigation-tracking/debouncing.html and ensured the following:

YT

  • ensured that clicking on Run returned to the test page and Observed Referrer --> dev-pages.brave.software
[25352:6152:0117/152421.321:VERBOSE1:debounce_throttle.cc(51)] SiteForCookies: {site=https://youtube.com; schemefully_same=true}
[25352:6152:0117/152421.321:VERBOSE1:debounce_throttle.cc(60)] Debouncing rule applied: https://www.youtube.com/redirect?q=https%3A%2F%2Fdev-pages.brave.software%2Fnavigation-tracking%2Fdebouncing.html%3Fcomplete -> https://dev-pages.brave.software/navigation-tracking/debouncing.html?complete

Reddit

  • ensured that clicking on Run returned to the test page and Observed Referrer --> dev-pages.brave.software
[25352:6152:0117/152133.778:VERBOSE1:debounce_throttle.cc(51)] SiteForCookies: {site=https://reddit.com; schemefully_same=true}
[25352:6152:0117/152133.778:VERBOSE1:debounce_throttle.cc(60)] Debouncing rule applied: https://out.reddit.com/test?url=https%3A%2F%2Fdev-pages.brave.software%2Fnavigation-tracking%2Fdebouncing.html%3Fcomplete -> https://dev-pages.brave.software/navigation-tracking/debouncing.html?complete

Disabled

Launched Brave using brave.exe --enable-logging=stderr --v=1 --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

YT

  • ensured that clicking on Run didn't return to the test page and Observed Referrer --> https://www.youtube.com when clicking on GO TO SITE
  • went through the logs and ensured that Debouncing rule applied wasn't visible as no rules are being applied

Reddit

  • ensured that clicking on Run didn't return to the test page (no debouncing occurring)
  • went through the logs and ensured that Debouncing rule applied wasn't visible as no rules are being applied

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #195 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants