Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screen farbling: update BETA min_version #562

Merged
merged 1 commit into from
Mar 23, 2023
Merged

screen farbling: update BETA min_version #562

merged 1 commit into from
Mar 23, 2023

Conversation

arthuredelstein
Copy link
Collaborator

No description provided.

@arthuredelstein arthuredelstein requested a review from a team as a code owner March 20, 2023 19:34
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging so QA can run through a few verifications on main (staging) before uplifting #493 into production.

@kjozwiak kjozwiak merged commit 2c5e6be into main Mar 23, 2023
@kjozwiak kjozwiak deleted the issues/491_fix branch March 23, 2023 04:45
@kjozwiak
Copy link
Member

For the above, going to simply check that BraveScreenFingerprintingBlockerStudy is being Enabled on BETA if they meet the minimum version requirements. It's been enabled on Nightlyfor some time so there's really no need to check anything onNightly`. Screen farbling a whole has also been QA'd a while ago but the rollout was stopped due to brave/brave-browser#27492.

Example of QA running through screen farbling:

Desktop verifications on Win 11 x64

BETA which meets the 111.1.50.93 minimum requirement

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.50.100 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1413)
  • launched 1.50.100 Chromium: 111.0.5563.64 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • visit brave://version and ensure that BraveScreenFingerprintingBlockerStudy is not visible
  • restart Brave once again using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensure that BraveScreenFingerprintingBlockerStudy:Enabled
Example Example
image image

BETA which doesn't meets the 111.1.50.93 minimum requirement

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.50.92 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1413)
  • launched 1.50.92 Chromium: 111.0.5563.64 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • visit brave://version and ensure that BraveScreenFingerprintingBlockerStudy is not visible
  • restart Brave once again using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensure that BraveScreenFingerprintingBlockerStudy doesn't appear via brave://version as it doesn't meet the minimum version requirement
Example Example
image image

Release - ensuring that BraveScreenFingerprintingBlockerStudy is not enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.49.128 Chromium: 111.0.5563.110 (Official Build) (64-bit)
-- | --
Revision | 3da375c9e9e5ad9b556af5df708a6e6c01d8cfb1-refs/branch-heads/5563@{#1202}
OS | Windows 11 Version 22H2 (Build 22621.1413)
  • launched 1.49.128 Chromium: 111.0.5563.110 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • visit brave://version and ensure that BraveScreenFingerprintingBlockerStudy is not visible
  • restart Brave once again using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensure that BraveScreenFingerprintingBlockerStudy:Default
Example Example
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants