Use non english spell check dict when available

Fix #1788

Auditors: @aekeus

CHANGELOG.md

@@ -18,6 +18,7 @@
 - Fixed pinned tabs sometimes duplicating. ([#1508](https://github.com/brave/browser-laptop/issues/1508))
 - Fixed Fullscreen mode showing a black bar up top on OS X. ([#1358](https://github.com/brave/browser-laptop/issues/1358))
 - Fixed contractions showing up as misspelled for spell check. ([#2015](https://github.com/brave/browser-laptop/issues/2015))
+- Fixed non-English spell checking dictionaries. ([#1788](https://github.com/brave/browser-laptop/issues/1788))
 - Possibly fixed intermittent problem with copy on OS X. ([#1060](https://github.com/brave/browser-laptop/issues/1060))
 - Upgrade to HTTPS Everywhere definitions for 5.1.9. ([#1692](https://github.com/brave/browser-laptop/issues/1692))
 - Upgrade to libchromiumcontent 51.0.2704.63. ([#1405](https://github.com/brave/browser-laptop/issues/1405))

app/spellCheck.js

@@ -13,6 +13,9 @@ const app = electron.app
 const appStore = require('../js/stores/appStore')
 const appActions = require('../js/actions/appActions')
 const contractionSet = new Set()
+const getSetting = require('../js/settings').getSetting
+const settings = require('../js/constants/settings')
+
 let dictionaryLocale
 
 // Stores a reference to the last added immutable words
@@ -68,13 +71,15 @@ module.exports.init = () => {
   contractions.forEach((word) => contractionSet.add(word.replace(/'.*/, '')))
 
   const availableDictionaries = spellchecker.getAvailableDictionaries()
-  let dict = app.getLocale().replace('-', '_')
+  let dict = getSetting(settings.LANGUAGE) || app.getLocale().replace('-', '_')
   if (availableDictionaries.includes(dict)) {
     dictionaryLocale = dict
+    spellchecker.setDictionary(dict)
   } else {
-    dict = app.getLocale().split('-')[0]
+    dict = dict.split('-')[0]
     if (availableDictionaries.includes(dict)) {
       dictionaryLocale = dict
+      spellchecker.setDictionary(dict)
     }
   }
 

js/constants/appConfig.js

@@ -72,7 +72,7 @@ module.exports = {
     winBaseUrl: `${winUpdateHost}/multi-channel/releases/CHANNEL/`
   },
   defaultSettings: {
-    'general.language': 'en-US',
+    'general.language': undefined,
     'general.startup-mode': 'lastTime',
     'general.homepage': 'https://www.brave.com',
     'general.show-home-button': false,