Styling fixes based on david's feedback

and add slash to end of torproject URL fix #14121
brave · Jun 21, 2018 · 265749a · 265749a
1 parent 80286fa
commit 265749a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/app/extensions/brave/about-newtab.html b/app/extensions/brave/about-newtab.html
@@ -17,6 +17,7 @@
     <script src="ext/l20n.min.js"></script>
     <script src="gen/aboutPages.entry.js" async></script>
     <link rel="localization" href="locales/{locale}/newtab.properties">
+    <link rel="localization" href="locales/{locale}/preferences.properties">
   </head>
   <body>
     <div id="appContainer"/>

diff --git a/app/extensions/brave/locales/en-US/newtab.properties b/app/extensions/brave/locales/en-US/newtab.properties
@@ -25,7 +25,7 @@ preferencesPage.title=Go to Preferences page
 privateTabsMore=More about private tabs
 privateTabText1=Whether or not you use Tor, private tabs are not logged in page history or counted in Brave Payments calculations. Private tabs and their cookies always vanish when the browser is closed.
 privateTabText2=If you use private tabs without Tor, the sites you visit will be visible to your ISP or your employer. You won’t be anonymous, and sites will learn your public IP address.
-privateTabText3=With Tor, Brave works hard to ensure that you’re extremely difficult to track online while providing a delightful browsing experience. But if your personal safety depends on remaining anonymous you may wish to use the Tor Browser from https://torproject.org instead.
+privateTabText3=With Tor, Brave works hard to ensure that you’re extremely difficult to track online while providing a delightful browsing experience. But if your personal safety depends on remaining anonymous you may wish to use the Tor Browser from https://torproject.org/ instead.
 privateTabTitle=This is a Private Tab
 privateTabTorTitle=Make private tabs much more private with
 privateTabTorText1=Tor hides your IP address from the sites you visit, and hides the sites you visit from your ISP or your employer. Tor can slow down browsing. Some sites treat anonymous users differently, or might not work at all. Some sites might even ask you to prove you’re human.

diff --git a/js/about/newprivatetab.js b/js/about/newprivatetab.js
@@ -40,6 +40,7 @@ class NewPrivateTab extends React.Component {
   onClickTorTitle () {
     const newSettingValue = !this.props.newTabData.getIn(torEnabled)
     aboutActions.changeSetting(settings.USE_TOR_PRIVATE_TABS, newSettingValue)
+    aboutActions.recreateTorTab(newSettingValue)
   }
 
   render () {
@@ -81,11 +82,12 @@ class NewPrivateTab extends React.Component {
               <div className={css(styles.privateSearch__setting)}>
                 <img className={css(styles.privateSearch__torImage)} src={torIcon} alt='Tor logo' />
                 <span>
-                  <h2 onClick={this.onClickPrivateSearchTitle.bind(this)} className={css(styles.privateSearch__title)}>
+                  <h2 onClick={this.onClickTorTitle.bind(this)} className={css(styles.privateSearch__title)}>
                     <span className={css(styles.text_sectionTitle)} data-l10n-id='privateTabTorTitle' />
-                    <strong className={css(styles.text_sectionTitle, styles.text_sectionTitleHighlight, styles.text_clickable)} onClick={aboutActions.createTabRequested.bind(null, {url: torFAQ})}>Tor</strong>
+                    <strong className={css(styles.text_sectionTitle, styles.text_sectionTitleHighlight)}>Tor</strong>
                   </h2>
                   <p className={css(styles.text, styles.text_privateSearch)} data-l10n-id='privateTabTorText1' />
+                  <p className={css(styles.text, styles.text_privateSearch, styles.text_clickable)} onClick={aboutActions.createTabRequested.bind(null, {url: torFAQ})} data-l10n-id='learnMore' />
                 </span>
                 <SettingCheckbox
                   large