tabs: only replace permanent contents

brave · Feb 22, 2018 · 2d576e5 · 2d576e5
1 parent 7d2fc77
commit 2d576e5
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/app/browser/tabs.js b/app/browser/tabs.js
@@ -620,10 +620,17 @@ const api = {
       })
 
       tab.on('tab-replaced-at', (e, windowId, tabIndex, newContents) => {
-        console.log(`tab ${tab.getId()} changed to`, {newTabId: newContents.getId(), tabIndex})
+        const isPlaceholder = newContents.isPlaceholder()
         const newTabId = newContents.getId()
+        if (isPlaceholder) {
+          if (shouldDebugTabEvents) {
+            console.log(`Tab [${tabId}] got a new placeholder (${newTabId}), not updating state.`)
+          }
+          return
+        }
+        // new contents is permanent replacement, e.g. tab has been discarded
         if (shouldDebugTabEvents) {
-          console.log(`Tab [${tabId}] changed to tabId ${newTabId}. Updating state references...`)
+          console.log(`Tab [${tabId}] permanently changed to tabId ${newTabId}. Updating state references...`)
         }
         // update state
         appActions.tabReplaced(tabId, getTabValue(newTabId), getTabValue(tabId).get('windowId'))