Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Use HTTPS over SSH for easier setup for most
Browse files Browse the repository at this point in the history
Auditors: @diracdeltas
  • Loading branch information
bbondy committed Jan 20, 2016
1 parent a77dc2c commit 4b49727
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,13 @@ Laptop and Desktop browser for OS X, Windows and Linux.

1. Shallow clone the git repository from GitHub:

# for beta testers
git clone --depth 1 git@github.com:brave/browser-laptop.git
# For beta testers:
git clone --depth 1 https://github.com/brave/browser-laptop

# for dev
# For devs over HTTPS:
git clone https://github.com/brave/browser-laptop

# For devs over SSH:
git clone git@github.com:brave/browser-laptop.git

2. Open the working directory:
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"dependencies": {
"abp-filter-parser-cpp": "^1.0.22",
"electron-localshortcut": "^0.6.0",
"electron-prebuilt": "git+ssh://git@github.com/brave/electron-prebuilt.git",
"electron-prebuilt": "https://github.com/brave/electron-prebuilt",
"electron-squirrel-startup": "^0.1.4",
"file-loader": "^0.8.5",
"font-awesome": "^4.5.0",
Expand All @@ -65,7 +65,7 @@
"tracking-protection": "^1.0.7",
"url-loader": "^0.5.7",
"urlutil.js": "^0.1.1",
"vibrant": "git+ssh://git@github.com/jariz/vibrant.js.git#1.0"
"vibrant": "https://github.com/jariz/vibrant.js#1.0"
},
"devDependencies": {
"asar": "^0.8.3",
Expand Down

2 comments on commit 4b49727

@diracdeltas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. one time, i had to make this exact change when i was staying in an airbnb that blocked port 22. :)

@bbondy
Copy link
Member Author

@bbondy bbondy commented on 4b49727 Jan 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, also I think if you have no key setup even if the repo is public then you can't pull from it... I think, not sure.

Please sign in to comment.