This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Register local shortcuts when creating BrowserWindow object.
This was reworked with 6d72210 and it was missed Fixes #7491 Auditor: @bridiver, @jonathansampson
- Loading branch information
5a889cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
5a889cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirmed this also fixed the Shift + F8 dev tools not working too 😄
5a889cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is called in on('show') a few lines below this call
5a889cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can move it, but it should only be called once
5a889cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bridiver ah- thanks... I'll remove the call that happens in show and test to make sure it works as expected on macOS too