Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Register local shortcuts when creating BrowserWindow object.
Browse files Browse the repository at this point in the history
This was reworked with 6d72210 and it was missed

Fixes #7491

Auditor: @bridiver, @jonathansampson
  • Loading branch information
bsclifton committed Mar 14, 2017
1 parent 02dff98 commit 5a889cc
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions app/browser/windows.js
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ const api = {
})
})

LocalShortcuts.register(win)

appActions.windowCreated(windowValue)
})
win.once('show', () => {
Expand Down

5 comments on commit 5a889cc

@jonathansampson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirmed this also fixed the Shift + F8 dev tools not working too 😄

@bridiver
Copy link
Collaborator

@bridiver bridiver commented on 5a889cc Mar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is called in on('show') a few lines below this call

@bridiver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can move it, but it should only be called once

@bsclifton
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bridiver ah- thanks... I'll remove the call that happens in show and test to make sure it works as expected on macOS too

Please sign in to comment.