This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove isFocused call from hide autofill event
This gets called pretty frequently by chromium into electron even if it's not showing Auditors: @bridiver
- Loading branch information
Showing
2 changed files
with
8 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -728,7 +728,7 @@ class Frame extends ImmutableComponent { | |
contextMenus.onShowAutofillMenu(e.suggestions, e.rect, this.frame) | ||
}) | ||
this.webview.addEventListener('hide-autofill-popup', (e) => { | ||
if (this.webview.isFocused()) { | ||
if (this.props.contextMenuDetail && this.props.contextMenuDetail.get('type') === 'autofill') { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
bbondy
Author
Member
|
||
windowActions.autofillPopupHidden(this.props.tabId) | ||
} | ||
}) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 comment
on commit 63edc2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't think this will work correctly. I did something very similar in windowState and we had to revert to using
isFocused
. Check with @darkdh