Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Add locale translation
Browse files Browse the repository at this point in the history
  • Loading branch information
darkdh committed Jul 17, 2016
1 parent 5b37100 commit 69bd164
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions app/extensions/brave/locales/en-US/app.properties
Original file line number Diff line number Diff line change
Expand Up @@ -149,3 +149,4 @@ flashTitle=Flash Object Blocked
flashRightClick=Right-click to run Adobe Flash
flashSubtext=from {{source}} on {{site}}.
flashExpirationText=Approvals reset 7 days after last visit.
prefsRestart=Do you want to restart now
2 changes: 1 addition & 1 deletion app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ app.on('ready', () => {
})

ipcMain.on(messages.PREFS_RESTART, () => {
var message = 'Do you want to restart now ?'
var message = locale.translation('prefsRestart') + '?'

This comment has been minimized.

Copy link
@luixxiul

luixxiul Jul 17, 2016

Contributor

I mean this '?'.

This comment has been minimized.

Copy link
@bbondy

bbondy Jul 18, 2016

Member

The ? should go in the localized string pls.

This comment has been minimized.

Copy link
@darkdh

darkdh Jul 18, 2016

Author Member

It's been fixed in the latest commit. Thanks.


appActions.showMessageBox({
buttons: ['Yes', 'No'],
Expand Down
3 changes: 2 additions & 1 deletion app/locale.js
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ var rendererIdentifiers = function () {
'historySuggestionTitle',
'aboutPagesSuggestionTitle',
'searchSuggestionTitle',
'topSiteSuggestionTitle'
'topSiteSuggestionTitle',
'prefsRestart'
]
}

Expand Down

0 comments on commit 69bd164

Please sign in to comment.