Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Removed the hacks of the buttons on the navigation bar (for Windows)
Browse files Browse the repository at this point in the history
Fixes #5928

Thanks to #5739 and #5750 (#5737) these hacks are no longer necessary.

Auditors: @srirambv

Test Plan:
1. Enable Home Button
2. Open some pages in the same tab to enable backButton and forwardButton
3. Make sure every place of the buttons are clickable
4. Make sure height and width of the buttons remain the same (34x24, 26x24)
5. Make sure stopButton is centered
6. Make sure the bookmark icon is properly aligned on each platforms
  • Loading branch information
Suguru Hirahara committed Dec 1, 2016
1 parent d1d91c0 commit a4a9bbe
Showing 1 changed file with 2 additions and 28 deletions.
30 changes: 2 additions & 28 deletions less/navigationBar.less
Original file line number Diff line number Diff line change
Expand Up @@ -36,25 +36,7 @@
padding-left: 5px;
}

.startButtons {
position: relative;
top: -1px;
}

#navigator {
margin-right: 0px;

.homeButton {
margin: 0 0 3px 0;
}

.stopButton {
margin: 0 2px 6px 2px;
}

.reloadButton {
margin: 0 3px 2px 3px;
}
input {
font-weight: 500;
margin: 1px 0 0 3px;
Expand All @@ -63,15 +45,6 @@

#urlInput { width: 100%; }

#navigator {
&:not(.titleMode) {
.bookmarkButtonContainer {
margin-top: 4px;
line-height: 24px;
}
}
}

// changes to ensure window can be as small as 480px wide
// and still be useable and have the caption buttons intact
@media (max-width: @breakpointExtensionButtonPadding) {
Expand Down Expand Up @@ -770,7 +743,8 @@
border-top-right-radius: 0;
border-bottom-right-radius: 0;
box-sizing: border-box;
display: block;
display: flex;
align-items: center;
height: 25px;
width: 25px;
}
Expand Down

0 comments on commit a4a9bbe

Please sign in to comment.