Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Hide bitwarden password manager until Brave has support for the expec…
Browse files Browse the repository at this point in the history 
…ted chrome API

Auditors: @kspearrin, @jonathansampson
  • Loading branch information
@bsclifton
bsclifton committed Jul 25, 2017
1 parent 609fbd2 commit a79effc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/about/preferences.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ class SecurityTab extends ImmutableComponent {
<option data-l10n-id='onePassword' value={passwordManagers.ONE_PASSWORD} />
<option data-l10n-id='dashlane' value={passwordManagers.DASHLANE} />
<option data-l10n-id='lastPass' value={passwordManagers.LAST_PASS} />
<option data-l10n-id='bitwarden' value={passwordManagers.BITWARDEN} />
{ /* <option data-l10n-id='bitwarden' value={passwordManagers.BITWARDEN} /> */ }
{ /* <option data-l10n-id='enpass' value={passwordManagers.ENPASS} /> */ }
<option data-l10n-id='doNotManageMyPasswords' value={passwordManagers.UNMANAGED} />
</SettingDropdown>
Expand Down

3 comments on commit a79effc

@kspearrin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Which APIs are causing issues now?

@bsclifton
Copy link
Member Author

@bsclifton bsclifton commented on a79effc Jul 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kspearrin we had an issue affecting all extensions which raised a popup (captured with #10029).

We just solved this a few minutes ago, so we might be able to give this a try again 😄 The commit above was just a cherry-pick from the last version

@kspearrin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Can you let me know if there is a build I can use to test bitwarden? I'd like to try things out myself with whatever candidate is coming up.

Please sign in to comment.