Merge branch '0.13.1-branch-orig'

brave · Jan 26, 2017 · af368d3 · af368d3
2 parents 4de7cf4 + 67b2326
commit af368d3
Show file tree

Hide file tree

Showing 110 changed files with 2,303 additions and 474 deletions.
diff --git a/app/browser/menu.js b/app/browser/menu.js
@@ -316,7 +316,7 @@ const createHistorySubmenu = () => {
       label: locale.translation('clearBrowsingData'),
       accelerator: 'Shift+CmdOrCtrl+Delete',
       click: function (item, focusedWindow) {
-        CommonMenu.sendToFocusedWindow(focusedWindow, [messages.SHORTCUT_OPEN_CLEAR_BROWSING_DATA_PANEL, {browserHistory: true}])
+        CommonMenu.sendToFocusedWindow(focusedWindow, [messages.SHORTCUT_OPEN_CLEAR_BROWSING_DATA_PANEL])
       }
     }
   ]
@@ -426,7 +426,6 @@ const createWindowSubmenu = () => {
 
 const createHelpSubmenu = () => {
   const submenu = [
-    CommonMenu.reportAnIssueMenuItem(),
     CommonMenu.separatorMenuItem,
     CommonMenu.submitFeedbackMenuItem(),
     {

diff --git a/app/cmdLine.js b/app/cmdLine.js
@@ -114,6 +114,7 @@ app.on('will-finish-launching', () => {
   // User clicked on a file or dragged a file to the dock on macOS
   app.on('open-file', (event, path) => {
     event.preventDefault()
+    path = encodeURI(path)
     if (!focusOrOpenWindow(path)) {
       newWindowURL = path
     }

diff --git a/app/common/commonMenu.js b/app/common/commonMenu.js
@@ -249,16 +249,6 @@ module.exports.importBrowserDataMenuItem = () => {
   }
 }
 
-module.exports.reportAnIssueMenuItem = () => {
-  return {
-    label: locale.translation('reportAnIssue'),
-    click: function (item, focusedWindow) {
-      module.exports.sendToFocusedWindow(focusedWindow,
-                                         [messages.SHORTCUT_NEW_FRAME, communityURL])
-    }
-  }
-}
-
 module.exports.submitFeedbackMenuItem = () => {
   return {
     label: locale.translation('submitFeedback'),

diff --git a/app/common/constants/settingsEnums.js b/app/common/constants/settingsEnums.js
@@ -21,8 +21,16 @@ const bookmarksToolbarMode = {
   FAVICONS_ONLY: 'faviconsOnly'
 }
 
+const tabCloseAction = {
+  LAST_ACTIVE: 'lastActive',
+  NEXT: 'next',
+  FIRST: 'first',
+  PARENT: 'parent'
+}
+
 module.exports = {
   startsWithOption,
   newTabMode,
-  bookmarksToolbarMode
+  bookmarksToolbarMode,
+  tabCloseAction
 }
diff --git a/app/common/state/aboutNewTabState.js b/app/common/state/aboutNewTabState.js
@@ -68,6 +68,7 @@ const getTopSites = (state) => {
   // remove folders; sort by visit count; enforce a max limit
   const sites = (state.get('sites') || new Immutable.List())
     .filter((site) => !siteUtil.isFolder(site))
+    .filter((site) => !siteUtil.isImportedBookmark(site))
     .filter((site) => !isSourceAboutUrl(site.get('location')))
     .sort(sortCountDescending)
     .slice(0, aboutNewTabMaxEntries)

diff --git a/app/extensions.js b/app/extensions.js
@@ -391,6 +391,12 @@ module.exports.init = () => {
       disableExtension(extensionIds[passwordManagers.LAST_PASS])
     }
 
+    if (activePasswordManager === passwordManagers.ENPASS) {
+      registerComponent(extensionIds[passwordManagers.ENPASS])
+    } else {
+      disableExtension(extensionIds[passwordManagers.ENPASS])
+    }
+
     if (getSetting(settings.POCKET_ENABLED)) {
       registerComponent(config.PocketExtensionId)
     } else {

diff --git a/app/extensions/brave/img/caret_down_grey.svg b/app/extensions/brave/img/caret_down_grey.svg
diff --git a/app/extensions/brave/locales/bn-BD/menu.properties b/app/extensions/brave/locales/bn-BD/menu.properties
@@ -87,7 +87,6 @@ preferences=পছন্দসমূহ
 settings=সেটিংস সমূহ...
 bookmarksManager=ম্যানেজার বুকমার্ক করুন...
 importBrowserData=ব্রাউজার ডেটা ইম্পোর্ট করুন
-reportAnIssue=অভিযোগ জানান
 submitFeedback=প্রতিক্রিয়া দাখিল  করুন 
 bookmarksToolbar=বুকমার্ক টুলবার
 bravery=Shields

diff --git a/app/extensions/brave/locales/bn-IN/menu.properties b/app/extensions/brave/locales/bn-IN/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferences…
 settings=Settings…
 bookmarksManager=Bookmarks Manager…
 importBrowserData=Import Browser Data…
-reportAnIssue=ত্রুটির খবর দিন
 submitFeedback=Submit Feedback…
 bookmarksToolbar=বুকমার্ক জন্ত্রপট
 bravery=Shields

diff --git a/app/extensions/brave/locales/cs/menu.properties b/app/extensions/brave/locales/cs/menu.properties
@@ -87,7 +87,6 @@ preferences=Nastavení...
 settings=Nastavení...
 bookmarksManager=Správce záložek...
 importBrowserData=Zavést data prohlížeče...
-reportAnIssue=Hlásit potíže
 submitFeedback=Odeslat zpětnou vazbu...
 bookmarksToolbar=Nástrojový panel záložek
 bravery=Štíty

diff --git a/app/extensions/brave/locales/de-DE/menu.properties b/app/extensions/brave/locales/de-DE/menu.properties
@@ -87,7 +87,6 @@ preferences=Einstellungen...
 settings=Einstellungen...
 bookmarksManager=Lesezeichen verwalten...
 importBrowserData=Browser-Daten importieren…
-reportAnIssue=Problem melden
 submitFeedback=Feedback senden...
 bookmarksToolbar=Lesezeichen-Symbolleiste
 bravery=Schutz

diff --git a/app/extensions/brave/locales/en-US/app.properties b/app/extensions/brave/locales/en-US/app.properties
@@ -55,6 +55,8 @@ reloadButton.title=Reload page
 homeButton.title=Open Homepage
 stopButton.title=Stop loading
 noScriptButton.title=Allow scripts
+enablePublisher.title=Enable publisher for payments
+disablePublisher.title=Disable publisher for payments
 braveMenu.title=Open Brave Shields Panel
 muteTab=Mute tab
 unmuteTab=Unmute tab

diff --git a/app/extensions/brave/locales/en-US/menu.properties b/app/extensions/brave/locales/en-US/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferences…
 settings=Settings…
 bookmarksManager=Bookmarks Manager…
 importBrowserData=Import Browser Data…
-reportAnIssue=Report an Issue
 submitFeedback=Submit Feedback…
 bookmarksToolbar=Bookmarks Toolbar
 bravery=Shields

diff --git a/app/extensions/brave/locales/en-US/preferences.properties b/app/extensions/brave/locales/en-US/preferences.properties
@@ -21,6 +21,7 @@ paymentsWelcomeText5=Note: Brave Payments uses a country-lookup service in order
 paymentsWelcomeText6=Need more info?
 paymentsWelcomeText7=for Brave Payments…
 paymentsWelcomeLink=View the FAQ
+paymentsFAQLink.title=View the FAQ
 paymentsSidebarText1=Our Partners
 paymentsSidebarText2=All transaction IP addresses are anonymized with technology from:
 paymentsSidebarText3=Brave Bitcoin Wallets are provided through a partnership with:
@@ -47,10 +48,12 @@ bitcoin=Bitcoin
 bitcoinAdd=Use your existing Bitcoin wallet/account
 bitcoinAddDescription=Use any BTC wallet that can transfer Bitcoin to your Brave wallet.
 bitcoinBuy=Buy Bitcoin
+noPaymentHistory=Your first payment contribution will be {{reconcileDate}}
 viewPaymentHistory=View Payment History…
 paymentHistoryTitle=Your Payment History
 paymentHistoryFooterText=Your next payment contribution is {{reconcileDate}}.
 paymentHistoryOKText=OK
+hideExcluded=Only show included sites
 bravePayments=Brave Payments
 beta=beta
 contributionDate=Contribution Date
@@ -83,6 +86,7 @@ off=off
 on=on
 ok=Ok
 minimumPercentage=Hide sites with less than 1% usage
+autoSuggestSites=auto-include sites
 notifications=Show notifications
 moneyAdd=Use your debit/credit card
 moneyAddSubTitle=No Bitcoin needed!
@@ -112,6 +116,7 @@ views=Views
 timeSpent=Time Spent
 include=Include
 percentage=%
+remove=Remove
 bravery=Bravery
 hintsTitle=Helpful hints
 hint0=The site shields panel allows you to turn HTTPS Everywhere on or off. HTTPS Everywhere automatically changes your HTTP traffic to HTTPS for supported sites to keep you more secure.
@@ -123,6 +128,10 @@ startsWith=Brave starts with
 startsWithOptionLastTime=My windows / tabs from last time
 startsWithOptionHomePage=Home page
 startsWithOptionNewTabPage=a new tab
+tabCloseActionLastActive=Last active tab
+tabCloseActionNext=Next tab
+tabCloseActionFirst=First tab
+tabCloseActionParent=Parent tab
 newTabMode=A new tab shows
 newTabBlank=blank
 newTabNewTabPage=Dashboard
@@ -137,6 +146,7 @@ engineGoKey=Engine Go Key (Type First)
 switchToNewTabs=Switch to new tabs immediately
 paintTabs=Show tabs in page theme color
 tabsPerTabPage=Number of tabs per tab set:
+tabCloseAction=Which tab should be activated after the tab is closed:
 showTabPreviews=Show tab previews on hover
 showHistoryMatches=Show history matches
 showBookmarkMatches=Show bookmark matches
@@ -158,6 +168,7 @@ backupLedger=Backup your wallet
 balanceRecovered={{balance}} BTC was recovered and transferred to your Brave wallet.
 recoverLedger=Recover your wallet
 recover=Recover
+recoverFromFile=Import recovery keys
 printKeys=Print keys
 saveRecoveryFile=Save recovery file...
 advancedPrivacySettings=Advanced Privacy Settings:
@@ -171,6 +182,7 @@ builtInPasswordManager=Brave Built-In
 onePassword=1Password&reg; (requires application)
 dashlane=Dashlane&reg; (requires application)
 lastPass=LastPass&reg;
+enpass=Enpass&reg; (requires application)
 doNotManageMyPasswords=Don't manage my passwords
 usePDFJS=Enable HTML5 PDF reader (requires browser restart)
 enableFlash=Enable Adobe Flash support

diff --git a/app/extensions/brave/locales/es/menu.properties b/app/extensions/brave/locales/es/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferencias…
 settings=Ajustes…
 bookmarksManager=Administrador de marcadores…
 importBrowserData=Importar datos del navegador...
-reportAnIssue=Reportar un problema
 submitFeedback=Enviar opinión…
 bookmarksToolbar=Barra de marcadores
 bravery=Escudos

diff --git a/app/extensions/brave/locales/eu/menu.properties b/app/extensions/brave/locales/eu/menu.properties
@@ -87,7 +87,6 @@ preferences=Hobespenak...
 settings=Hobespenak...
 bookmarksManager=Laster-marken hobespenak
 importBrowserData=Nabigatzailearen datuak inportatu...
-reportAnIssue=Arazo bati buruz ohartarazi
 submitFeedback=Iruzkina bidali...
 bookmarksToolbar=Laster-markaren erreminta taula 
 bravery=Shields

diff --git a/app/extensions/brave/locales/fr-FR/menu.properties b/app/extensions/brave/locales/fr-FR/menu.properties
@@ -87,7 +87,6 @@ preferences=Préférences…
 settings=Paramètres…
 bookmarksManager=Gestionnaire de signets…
 importBrowserData=Importer les données d'un navigateur...
-reportAnIssue=Remonter un problème
 submitFeedback=Envoyer votre avis…
 bookmarksToolbar=Barre des signets
 bravery=Boucliers

diff --git a/app/extensions/brave/locales/hi-IN/menu.properties b/app/extensions/brave/locales/hi-IN/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferences…
 settings=Settings…
 bookmarksManager=Bookmarks Manager…
 importBrowserData=Import Browser Data…
-reportAnIssue=विवाद दर्ज करें 
 submitFeedback=Submit Feedback…
 bookmarksToolbar=पुस्तचिह्ननित औज़ारपट्टी  
 bravery=Shields

diff --git a/app/extensions/brave/locales/id-ID/menu.properties b/app/extensions/brave/locales/id-ID/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferensi…
 settings=Pengaturan...
 bookmarksManager=Pengelola Markah…
 importBrowserData=Impor Data Peramban...
-reportAnIssue=Laporkan Masalah
 submitFeedback=Kirim Saran…
 bookmarksToolbar=Bilah Alat Markah
 bravery=Perisai

diff --git a/app/extensions/brave/locales/it-IT/menu.properties b/app/extensions/brave/locales/it-IT/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferenze...
 settings=Impostazioni...
 bookmarksManager=Gestione Segnalibri...
 importBrowserData=Importa Dati Browser...
-reportAnIssue=Riporta un problema
 submitFeedback=Invia Opinione...
 bookmarksToolbar=Barra dei segnalibri
 bravery=Protezione

diff --git a/app/extensions/brave/locales/ja-JP/menu.properties b/app/extensions/brave/locales/ja-JP/menu.properties
@@ -87,7 +87,6 @@ preferences=設定
 settings=設定
 bookmarksManager=ブックマーク マネージャー
 importBrowserData=ブラウザーデータをインポート
-reportAnIssue=問題を報告
 submitFeedback=フィードバックを送信
 bookmarksToolbar=ブックマーク ツールバー
 bravery=保護設定

diff --git a/app/extensions/brave/locales/ko-KR/menu.properties b/app/extensions/brave/locales/ko-KR/menu.properties
@@ -87,7 +87,6 @@ preferences=환경 설정...
 settings=설정...
 bookmarksManager=북마크 관리자...
 importBrowserData=브라우저 데이터 가져오기...
-reportAnIssue=문제 신고
 submitFeedback=피드백 제출하기...
 bookmarksToolbar=북마크 툴바
 bravery=Shields

diff --git a/app/extensions/brave/locales/ms-MY/menu.properties b/app/extensions/brave/locales/ms-MY/menu.properties
@@ -87,7 +87,6 @@ preferences=Keutamaan
 settings=Tetapan...
 bookmarksManager=Pengurus Tandabuku...
 importBrowserData=Import Data Pelayar...
-reportAnIssue=Laporkan Isu
 submitFeedback=Hantar Maklum balas...
 bookmarksToolbar=Bar alatan Tandabuku
 bravery=Perisai

diff --git a/app/extensions/brave/locales/nl-NL/menu.properties b/app/extensions/brave/locales/nl-NL/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferences…
 settings=Settings…
 bookmarksManager=Bookmarks Manager…
 importBrowserData=Import Browser Data…
-reportAnIssue=Report an Issue
 submitFeedback=Submit Feedback…
 bookmarksToolbar=Bookmarks Toolbar
 bravery=Shields

diff --git a/app/extensions/brave/locales/pl-PL/menu.properties b/app/extensions/brave/locales/pl-PL/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferences…
 settings=Settings…
 bookmarksManager=Bookmarks Manager…
 importBrowserData=Import Browser Data…
-reportAnIssue=Zgłoś problem
 submitFeedback=Submit Feedback…
 bookmarksToolbar=Pasek zakładek
 bravery=Shields

diff --git a/app/extensions/brave/locales/pt-BR/menu.properties b/app/extensions/brave/locales/pt-BR/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferências...
 settings=Configurações...
 bookmarksManager=Gestor de Marcadores...
 importBrowserData=Importar Dados do Navegador... 
-reportAnIssue=Relatar um Problema
 submitFeedback=Submeter Feedback… 
 bookmarksToolbar=Barra de Favoritos
 bravery=Escudos

diff --git a/app/extensions/brave/locales/ru/menu.properties b/app/extensions/brave/locales/ru/menu.properties
@@ -87,7 +87,6 @@ preferences=Настройки...
 settings=Настройки...
 bookmarksManager=Менеджер закладок...
 importBrowserData=Импорт данных браузера...
-reportAnIssue=Сообщить о проблеме
 submitFeedback=Оставить отзыв...
 bookmarksToolbar=Панель закладок
 bravery=Щиты

diff --git a/app/extensions/brave/locales/sl/menu.properties b/app/extensions/brave/locales/sl/menu.properties
@@ -87,7 +87,6 @@ preferences=Nastavitve ...
 settings=Nastavitve ...
 bookmarksManager=Upravitelj zaznamkov ...
 importBrowserData=Uvozi podatke brskalnika ...
-reportAnIssue=Poročajte o težavi
 submitFeedback=Pošlji odziv ...
 bookmarksToolbar=Orodna vrstica zaznamkov
 bravery=Ščiti

diff --git a/app/extensions/brave/locales/ta/menu.properties b/app/extensions/brave/locales/ta/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferences…
 settings=Settings…
 bookmarksManager=Bookmarks Manager…
 importBrowserData=Import Browser Data…
-reportAnIssue=பிரச்சனையை புகாரளி
 submitFeedback=Submit Feedback…
 bookmarksToolbar=புத்தகக்குறி கருவிப்பட்டை
 bravery=Shields

diff --git a/app/extensions/brave/locales/te/menu.properties b/app/extensions/brave/locales/te/menu.properties
@@ -87,7 +87,6 @@ preferences=Preferences…
 settings=Settings…
 bookmarksManager=Bookmarks Manager…
 importBrowserData=Import Browser Data…
-reportAnIssue=ఇష్యూ మాకు చెప్పుము 
 submitFeedback=Submit Feedback…
 bookmarksToolbar=బుక్ మార్క్స్ టూల్ బార్ 
 bravery=Shields

diff --git a/app/extensions/brave/locales/tr-TR/menu.properties b/app/extensions/brave/locales/tr-TR/menu.properties
@@ -87,7 +87,6 @@ preferences=Ayarlar
 settings=Ayarlar
 bookmarksManager=Yerimleri Yöneticisi
 importBrowserData=Tarayıcı Verilerini Yükle
-reportAnIssue=Bir Hata Bildirin
 submitFeedback=Geri Bildirim Gönder
 bookmarksToolbar=Yerimleri Araç Çubuğu
 bravery=Kalkanlar

diff --git a/app/extensions/brave/locales/uk/menu.properties b/app/extensions/brave/locales/uk/menu.properties
@@ -87,7 +87,6 @@ preferences=Налаштування…
 settings=Налаштування…
 bookmarksManager=Керування закладками…
 importBrowserData=Імпорт даних перегляду…
-reportAnIssue=Повідомити про проблему
 submitFeedback=Надіслати відгук…
 bookmarksToolbar=Панель закладок
 bravery=Щити

diff --git a/app/extensions/brave/locales/zh-CN/menu.properties b/app/extensions/brave/locales/zh-CN/menu.properties
@@ -87,7 +87,6 @@ preferences=首选项...
 settings=设置...
 bookmarksManager=书签管理器...
 importBrowserData=导入浏览器数据...
-reportAnIssue=报告问题
 submitFeedback=提交反馈...
 bookmarksToolbar=书签工具栏
 bravery=屏蔽

diff --git a/app/filtering.js b/app/filtering.js
@@ -490,12 +490,14 @@ function registerForDownloadListener (session) {
     }
 
     const defaultPath = path.join(getSetting(settings.DEFAULT_DOWNLOAD_SAVE_PATH) || app.getPath('downloads'), itemFilename)
-    const savePath = dialog.showSaveDialog(win, { defaultPath })
+    const savePath = (process.env.SPECTRON ? defaultPath : dialog.showSaveDialog(win, { defaultPath }))
+
     // User cancelled out of save dialog prompt
     if (!savePath) {
       event.preventDefault()
       return
     }
+
     item.setSavePath(savePath)
     appActions.changeSetting(settings.DEFAULT_DOWNLOAD_SAVE_PATH, path.dirname(savePath))
 

diff --git a/app/index.js b/app/index.js
@@ -9,6 +9,10 @@ let ready = false
 
 // Setup the crash handling
 const CrashHerald = require('./crash-herald')
+const telemetry = require('./telemetry')
+
+// set initial base line checkpoint
+telemetry.setCheckpoint('init')
 
 const handleUncaughtError = (error) => {
   var message, ref, stack
@@ -241,6 +245,7 @@ let loadAppStatePromise = SessionStore.loadAppState()
 
 // Some settings must be set right away on startup, those settings should be handled here.
 loadAppStatePromise.then((initialState) => {
+  telemetry.setCheckpointAndReport('state-loaded')
   const {HARDWARE_ACCELERATION_ENABLED, SMOOTH_SCROLL_ENABLED, SEND_CRASH_REPORTS} = require('../js/constants/settings')
   if (initialState.settings[HARDWARE_ACCELERATION_ENABLED] === false) {
     app.disableHardwareAcceleration()