Use proper notification message

brave · May 8, 2017 · b8fc59c · b8fc59c
1 parent e9158b5
commit b8fc59c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/app/browser/reducers/autoplayReducer.js b/app/browser/reducers/autoplayReducer.js
@@ -21,7 +21,7 @@ const showAutoplayMessageBox = (location, tabId) => {
   if (originSettings && originSettings.get('noAutoplay') === true) {
     return
   }
-  const message = locale.translation('autoplayBlocked', {origin})
+  const message = locale.translation('allowAutoplay', {origin})
 
   appActions.showNotification({
     buttons: [

diff --git a/app/extensions/brave/locales/en-US/app.properties b/app/extensions/brave/locales/en-US/app.properties
@@ -260,4 +260,4 @@ copied=Copied!
 connectionError=Server connection failed. Please make sure you are connected to the Internet.
 unknownError=Oops, something went wrong.
 browserActionButton.title={{name}}
-autoplayBlocked=Media autoplay on {{origin}} has been blocked. Do you want to allow it?
+allowAutoplay=Allow {{origin}} to autoplay media?
diff --git a/app/locale.js b/app/locale.js
@@ -252,7 +252,7 @@ var rendererIdentifiers = function () {
     'importSuccessOk',
     'connectionError',
     'unknownError',
-    'autoplayBlocked'
+    'allowAutoplay'
   ]
 }
 

diff --git a/test/bravery-components/braveryPanelTest.js b/test/bravery-components/braveryPanelTest.js
@@ -521,7 +521,7 @@ describe('Bravery Panel', function () {
         .windowByUrl(Brave.browserWindowUrl)
         .waitForExist(notificationBar)
         .waitUntil(function () {
-          return this.getText(notificationBar).then((val) => val.includes('Media autoplay'))
+          return this.getText(notificationBar).then((val) => val.includes('autoplay media'))
         })
     })
 
@@ -539,7 +539,7 @@ describe('Bravery Panel', function () {
         .windowByUrl(Brave.browserWindowUrl)
         .waitForExist(notificationBar)
         .waitUntil(function () {
-          return this.getText(notificationBar).then((val) => val.includes('Media autoplay'))
+          return this.getText(notificationBar).then((val) => val.includes('autoplay media'))
         })
         .openBraveMenu(braveMenu, braveryPanel)
         .click(noAutoplaySwitch)
@@ -567,7 +567,7 @@ describe('Bravery Panel', function () {
         .windowByUrl(Brave.browserWindowUrl)
         .waitForExist(notificationBar)
         .waitUntil(function () {
-          return this.getText(notificationBar).then((val) => val.includes('Media autoplay'))
+          return this.getText(notificationBar).then((val) => val.includes('autoplay media'))
         })
         .openBraveMenu(braveMenu, braveryPanel)
         .click(noAutoplaySwitch)
@@ -595,7 +595,7 @@ describe('Bravery Panel', function () {
         .windowByUrl(Brave.browserWindowUrl)
         .waitForExist(notificationBar)
         .waitUntil(function () {
-          return this.getText(notificationBar).then((val) => val.includes('Media autoplay'))
+          return this.getText(notificationBar).then((val) => val.includes('autoplay media'))
         })
         .click('button=Yes')
         .tabByUrl(url)
@@ -621,7 +621,7 @@ describe('Bravery Panel', function () {
         .windowByUrl(Brave.browserWindowUrl)
         .waitForExist(notificationBar)
         .waitUntil(function () {
-          return this.getText(notificationBar).then((val) => val.includes('Media autoplay'))
+          return this.getText(notificationBar).then((val) => val.includes('autoplay media'))
         })
         .click('[data-l10n-id=rememberDecision]')
         .click('button=No')