don't default empty title to the url

auditors: @bbondy
brave · Aug 27, 2016 · d5c41e3 · d5c41e3 · bbondy · Aug 27, 2016
1 parent 0c72d33
commit d5c41e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/js/components/addEditBookmark.js b/js/components/addEditBookmark.js
@@ -121,7 +121,7 @@ class AddEditBookmark extends ImmutableComponent {
     if (this.props.currentDetail.get('customTitle') !== undefined) {
       return this.props.currentDetail.get('customTitle')
     }
-    return this.props.currentDetail.get('title') || this.props.currentDetail.get('location')
+    return this.props.currentDetail.get('title') || ''
   }
   render () {
     return <Dialog onHide={this.onClose} isClickDismiss>

diff --git a/test/components/bookmarksTest.js b/test/components/bookmarksTest.js
@@ -64,10 +64,10 @@ describe('bookmarks', function () {
         .waitForVisible(saveButton)
     })
 
-    it('fills in the url for the title field', function * () {
+    it('leaves the title field blank', function * () {
       yield this.app.client
         .waitForExist('#bookmarkName input')
-        .getValue('#bookmarkName input').should.eventually.be.equal(this.page1Url)
+        .getValue('#bookmarkName input').should.eventually.be.equal('')
     })
 
     it('fills in the url field', function * () {