Use app action for opening update log

Fix #9122

Auditors: @cezaraugusto

app/browser/reducers/updatesReducer.js

@@ -0,0 +1,20 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+'use strict'
+
+const appConstants = require('../../../js/constants/appConstants')
+const path = require('path')
+const {app, shell} = require('electron')
+
+const updatesReducer = (state, action) => {
+  switch (action.actionType) {
+    case appConstants.APP_UPDATE_LOG_OPENED:
+      shell.openItem(path.join(app.getPath('userData'), 'updateLog.log'))
+      break
+  }
+  return state
+}
+
+module.exports = updatesReducer

app/renderer/components/main/updateBar.js

@@ -79,7 +79,7 @@ class UpdateHide extends ImmutableComponent {
 
 class UpdateLog extends ImmutableComponent {
   onViewLog () {
-    remote.shell.openItem(path.join(remote.app.getPath('userData'), 'updateLog.log'))
+    appActions.updateLogOpened()
   }
   render () {
     return <BrowserButton notificationItem secondaryColor

js/actions/appActions.js

@@ -1402,6 +1402,15 @@ const appActions = {
       actionType: appConstants.APP_DEFAULT_SEARCH_ENGINE_LOADED,
       searchDetail
     })
+  },
+
+  /**
+   * Dispatches a message to indicate that the update log is being opened
+   */
+  updateLogOpened: function (searchDetail) {
+    dispatch({
+      actionType: appConstants.APP_UPDATE_LOG_OPENED
+    })
   }
 
 }

js/constants/appConstants.js

@@ -130,7 +130,8 @@ const appConstants = {
   APP_ADD_PASSWORD: _, /** @param {Object} passwordDetail */
   APP_REMOVE_PASSWORD: _, /** @param {Object} passwordDetail */
   APP_REMOVE_PASSWORD_SITE: _, /** @param {Object} passwordDetail */
-  APP_CLEAR_PASSWORDS: _
+  APP_CLEAR_PASSWORDS: _,
+  APP_UPDATE_LOG_OPENED: _
 }
 
 module.exports = mapValuesByKeys(appConstants)

js/stores/appStore.js

@@ -400,7 +400,8 @@ const handleAppAction = (action) => {
       require('../../app/browser/reducers/tabMessageBoxReducer'),
       require('../../app/browser/reducers/dragDropReducer'),
       require('../../app/browser/reducers/extensionsReducer'),
-      require('../../app/browser/reducers/shareReducer')
+      require('../../app/browser/reducers/shareReducer'),
+      require('../../app/browser/reducers/updatesReducer')
     ]
     initialized = true
     appState = action.appState

test/unit/app/browser/reducers/updatesReducerTest.js

@@ -0,0 +1,46 @@
+/* global describe, it, before, after */
+const mockery = require('mockery')
+const sinon = require('sinon')
+const Immutable = require('immutable')
+const assert = require('assert')
+const fakeElectron = require('../../../lib/fakeElectron')
+
+const appConstants = require('../../../../../js/constants/appConstants')
+require('../../../braveUnit')
+
+describe('updatesReducer', function () {
+  let updatesReducer
+  before(function () {
+    mockery.enable({
+      warnOnReplace: false,
+      warnOnUnregistered: false,
+      useCleanCache: true
+    })
+    mockery.registerMock('electron', fakeElectron)
+    updatesReducer = require('../../../../../app/browser/reducers/updatesReducer')
+  })
+
+  after(function () {
+    mockery.disable()
+  })
+
+  describe('APP_UPDATE_LOG_OPENED', function () {
+    before(function () {
+      this.openItemSpy = sinon.spy(fakeElectron.shell, 'openItem')
+      this.getPathMock = sinon.mock(fakeElectron.app, 'getPath', () => '')
+      // Make sure updatesReducer doesn't update state when text is updated
+      this.newState = updatesReducer(Immutable.Map(), {actionType: appConstants.APP_UPDATE_LOG_OPENED})
+    })
+    after(function () {
+      this.openItemSpy.restore()
+      this.getPathMock.restore()
+    })
+    it('Does not modify state', function () {
+      assert(this.newState.isEmpty())
+    })
+    it('Opens update log path', function () {
+      assert(this.openItemSpy.calledOnce)
+      assert(this.openItemSpy.args[0][0].endsWith('updateLog.log'))
+    })
+  })
+})