Toggle method for menu can now include bool; default is that it'll to…

…ggle.
brave · Sep 12, 2016 · dd23cbd · dd23cbd
1 parent 55e76da
commit dd23cbd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/js/actions/windowActions.js b/js/actions/windowActions.js
@@ -990,10 +990,12 @@ const windowActions = {
   /**
    * (Windows only)
    * Dispatches a message to indicate the custom rendered Menubar should be toggled (shown/hidden)
+   * @param {boolean} isVisible (optional)
    */
-  toggleMenubarVisible: function () {
+  toggleMenubarVisible: function (isVisible) {
     dispatch({
-      actionType: WindowConstants.WINDOW_TOGGLE_MENUBAR_VISIBLE
+      actionType: WindowConstants.WINDOW_TOGGLE_MENUBAR_VISIBLE,
+      isVisible
     })
   },
 

diff --git a/js/stores/windowStore.js b/js/stores/windowStore.js
@@ -775,8 +775,12 @@ const doAction = (action) => {
       break
     case WindowConstants.WINDOW_TOGGLE_MENUBAR_VISIBLE:
       if (getSetting(settings.AUTO_HIDE_MENU)) {
-        const currentStatus = windowState.getIn(['ui', 'menubar', 'isVisible'])
-        windowState = windowState.setIn(['ui', 'menubar', 'isVisible'], !currentStatus)
+        if (typeof action.isVisible === 'boolean'){
+          windowState = windowState.setIn(['ui', 'menubar', 'isVisible'], action.isVisible)
+        } else {
+          const currentStatus = windowState.getIn(['ui', 'menubar', 'isVisible'])
+          windowState = windowState.setIn(['ui', 'menubar', 'isVisible'], !currentStatus)
+        }
       }
       break