Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Regression appears to have reset the webkit drag attribute on navigat…
Browse files Browse the repository at this point in the history 
…ion buttons. This is especially important for Windows, because its BrowserWindow is using the FramelessWindow.

Fixes #6253

Auditors: @bbondy, @luixxiul
  • Loading branch information
@bsclifton
bsclifton committed Dec 21, 2016
1 parent bb56af5 commit ef4bb2f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions less/navigationBar.less
View file
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,8 @@
background: white;
box-shadow: 0px 1px 5px 0px rgba(0, 0, 0, 0.15);
}

-webkit-app-region: no-drag;
}

.noScriptButtonContainer {
Expand Down

2 comments on commit ef4bb2f

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented on ef4bb2f Dec 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

I still would set -webkit-app-region: no-drag; to #navigator and set -webkit-app-region: drag to .endbutton > .browserButton (which is empty for now and will be removed after the PNG sprite is impelemented). I think this would prevent regressing.

<- this makes the span between the reload button and the bookmark button undraggable :-(

@luixxiul
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a PR to apply the property to all descendants under #navigator: #6681

Please sign in to comment.