Don't show-up siteInfo modal for url searches

Auditors: @diracdeltas
Close #9172
Test Plan:
covered by automated tests

app/renderer/components/main/siteInfo.js

@@ -231,7 +231,7 @@ class SiteInfo extends ImmutableComponent {
         </div>
     }
 
-    return <Dialog onHide={this.props.onHide} className='siteInfo' isClickDismiss>
+    return <Dialog testId='siteInfoDialog' onHide={this.props.onHide} className='siteInfo' isClickDismiss>
       <div onClick={(e) => e.stopPropagation()}
         className={cx({
           [css(commonStyles.flyoutDialog)]: true,

app/renderer/components/navigation/urlBarIcon.js

@@ -84,7 +84,7 @@ class UrlBarIcon extends ImmutableComponent {
     }
   }
   onClick () {
-    if (isSourceAboutUrl(this.props.location)) {
+    if (isSourceAboutUrl(this.props.location) || this.isSearch) {
       return
     }
     windowActions.setSiteInfoVisible(true)

test/lib/selectors.js

@@ -16,7 +16,7 @@ module.exports = {
   tabPage1: '[data-tab-page="0"]',
   tabPage2: '[data-tab-page="1"]',
   closeTab: '[data-test-id="closeTabIcon"]',
-  urlbarIcon: '.urlbarIcon',
+  urlbarIcon: '[data-test-id="urlBarIcon"]',
   urlBarSuggestions: '.urlBarSuggestions',
   titleBar: '#titleBar',
   navigatorBookmarked: '#navigator .removeBookmarkButton',
@@ -125,5 +125,7 @@ module.exports = {
   downloadReDownload: '[data-test-id="redownloadButton"]',
   downloadDelete: '[data-test-id="deleteButton"]',
   downloadDeleteConfirm: '[data-test-id="confirmDeleteButton"]',
-  downloadRemoveFromList: '[data-test-id="downloadRemoveFromList"]'
+  downloadRemoveFromList: '[data-test-id="downloadRemoveFromList"]',
+
+  siteInfoDialog: '[data-test-id="siteInfoDialog"]'
 }

test/unit/app/renderer/components/navigation/urlBarIconTest.js

@@ -57,6 +57,25 @@ describe('UrlBarIcon component unit tests', function () {
     windowActions.setSiteInfoVisible.restore()
   })
 
+  describe('when user is searching', function () {
+    const props2 = Object.assign({}, props)
+
+    before(function () {
+      props2.isSearching = true
+      props2.titleMode = false
+    })
+
+    it('does not show site information when clicked', function () {
+      const spy = sinon.spy(windowActions, 'setSiteInfoVisible')
+      const wrapper = mount(
+        <UrlBarIcon {...props2} />
+      )
+      wrapper.find('[data-test-id="urlBarIcon"]').simulate('click')
+      assert.equal(spy.notCalled, true)
+      windowActions.setSiteInfoVisible.restore()
+    })
+  })
+
   describe('when active tab is showing a message box', function () {
     const props2 = Object.assign({}, props)