Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Optimize getToolbarBookmarks #10009

Closed
bbondy opened this issue Jul 17, 2017 · 0 comments
Closed

Optimize getToolbarBookmarks #10009

bbondy opened this issue Jul 17, 2017 · 0 comments
Assignees
@bbondy
Labels
perf QA/no-qa-needed release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@bbondy
Copy link
Member

bbondy commented Jul 17, 2017

getToolbarBookmarks is expensive and it's currently called in mergeProps which would be the reason why things have gotten worse with perf.

screen shot 2017-07-16 at 10 51 30 pm

After optimizing:
screen shot 2017-07-16 at 11 16 45 pm
@bbondy bbondy added this to the 0.18.x (Release Channel) milestone Jul 17, 2017
bbondy added a commit that referenced this issue Jul 17, 2017
@bbondy
Optimize getToolbarBookmarks
727f762 
Fix #10009
@bbondy bbondy self-assigned this Jul 17, 2017
bbondy added a commit that referenced this issue Jul 17, 2017
@bbondy
Optimize getToolbarBookmarks
aff637f 
Fix #10009
bbondy added a commit that referenced this issue Jul 17, 2017
@bbondy
Optimize getToolbarBookmarks
0dd9824 
Fix #10009
@bbondy bbondy modified the milestones: 0.18.x (Release Channel), 0.17.17 (Release Channel) Jul 17, 2017
@bbondy bbondy mentioned this issue Jul 17, 2017
Merged
8 tasks
@bbondy bbondy modified the milestones: 0.19.x (Beta Channel), 0.17.17 (Release Channel) Jul 17, 2017
@cndouglas cndouglas added the perf label Jul 17, 2017
bbondy added a commit that referenced this issue Jul 17, 2017
@bbondy
Optimize getToolbarBookmarks
daa7a8d 
Fix #10009
NejcZdovc pushed a commit that referenced this issue Jul 18, 2017
@bbondy @NejcZdovc
Optimize getToolbarBookmarks
09a49bc 
Fix #10009
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
perf QA/no-qa-needed release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
3 participants
@bbondy @luixxiul @cndouglas