Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

data: URL warning popup should disappear when the window is navigated #10039

Closed
diracdeltas opened this issue Jul 18, 2017 · 0 comments · Fixed by #10046
Closed

data: URL warning popup should disappear when the window is navigated #10039

diracdeltas opened this issue Jul 18, 2017 · 0 comments · Fixed by #10046

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jul 18, 2017

Test plan

#10046 (comment)


related: #9572

the siteInfo popup appears on 'data:' URLs to prevent phishing attacks, but it should disappear when the page is navigated away to a non-data URL

@diracdeltas diracdeltas self-assigned this Jul 18, 2017
@diracdeltas diracdeltas added this to the 0.20.x (Developer Channel) milestone Jul 18, 2017
diracdeltas added a commit that referenced this issue Jul 18, 2017
fix #10039

Test Plan:
1. go to data:text/html,<meta http-equiv="refresh" content="1; url=https://example.com/">
2. confirm that the siteinfo popup appears for a second then disappears when the site changes to example.com
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
fix brave#10039

Test Plan:
1. go to data:text/html,<meta http-equiv="refresh" content="1; url=https://example.com/">
2. confirm that the siteinfo popup appears for a second then disappears when the site changes to example.com
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.