Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Browser freezes per 5 minutes with existing profile #10094

Closed
luixxiul opened this issue Jul 23, 2017 · 8 comments
Closed

Browser freezes per 5 minutes with existing profile #10094

luixxiul opened this issue Jul 23, 2017 · 8 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 23, 2017

Test plan

#10305 (comment)


Describe the issue you encountered: Browser freezes with existing profile. The issue is not reproducible for me on macOS. I have not tested the issue on a linux distribution or Windows 7.

A related issue was reported here: https://community.brave.com/t/brave-freezes-after-short-period-of-being-idle/4783/10

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

  • Brave Version (revision SHA): 0.17.19

  • Steps to reproduce:

    1. Use the browser long (to load much data on the browser's profile)
    2. Load a youtube video (to make the lag noticiable)
  • Actual result: the browser freezes for seconds per some minutes

  • Expected result: the browser should not freeze

  • Will the steps above reproduce in a fresh profile?
    No, I don't think so.

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues: short term video freezes #9808 Tracking: Critical performance tracking issue #9311

@luixxiul
Copy link
Contributor Author

According to this report, the issue can be reproduced on macOS too: https://community.brave.com/t/browser-frequently-freezes-mac-osx/4923/3?u=suguru

@luixxiul luixxiul changed the title Browser freezes with existing profile on Windows 10 Browser freezes with existing profile Jul 23, 2017
@luixxiul luixxiul changed the title Browser freezes with existing profile Browser freezes per 5 minutes with existing profile Aug 2, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 2, 2017

I noticed that the browser freezed around each 5 minutes whether the browser window was active or not. I suspect that the issue is related with writing/reading data and that writing data locks the UI process.

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 2, 2017

@bsclifton / @bridiver what do you think about ^?

On #5512 (comment)

Session should auto-save itself every 5 minutes. (added with 931facf)

If the value here is changed to 1 * 60 * 1000 and the UI is locked each minute, then I think it is highly likely that the saving session file locks the UI.

I would like to test that, if test build is released for testing. Also there are some users reporting the similar issue on community, and we would be able to ask them to run the binary to verify the issue.

@bsclifton
Copy link
Member

A potential fix for the underlying issue may be possible with upcoming Muon build (see brave/muon@57ecc85). Once this is built, we can update browser-laptop to use this sendShared method

cc: @bridiver @bbondy

@bridiver
Copy link
Collaborator

bridiver commented Aug 3, 2017

@luixxiul I don't think that saving the session file is causing the UI to lock because it happens on a separate thread. What is more likely causing the UI to lock is the ipc transfer of the window state that @bsclifton referenced

bbondy added a commit that referenced this issue Aug 4, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
bbondy added a commit that referenced this issue Aug 4, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
bbondy added a commit that referenced this issue Aug 5, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
@luixxiul luixxiul added this to the 0.18.x Hotfix milestone Aug 6, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 8, 2017

Added the milestone based on #10305 (comment)

bbondy added a commit that referenced this issue Aug 8, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
bbondy added a commit that referenced this issue Aug 8, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
bbondy added a commit that referenced this issue Aug 8, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
bbondy added a commit that referenced this issue Aug 8, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
bbondy added a commit that referenced this issue Aug 8, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
bbondy added a commit that referenced this issue Aug 8, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
bbondy added a commit that referenced this issue Aug 9, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
bbondy added a commit that referenced this issue Aug 9, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
bbondy added a commit that referenced this issue Aug 9, 2017
Fix #10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 9, 2017

Playing 30 min video on Netflix, the browser's UI was not locked at all :-)

bbondy added a commit that referenced this issue Aug 15, 2017
bbondy added a commit that referenced this issue Aug 15, 2017
bbondy added a commit that referenced this issue Aug 15, 2017
bbondy added a commit that referenced this issue Aug 15, 2017
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
Fix brave#10094

The problem is with toJS being called to convert the immutable app state

Instead we just keep everything in Immutable
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@luixxiul
Copy link
Contributor Author

Recently Netflix video started freezing for a couple of seconds again. It happens sometimes. I am not sure how to reproduce the issue. I am wondering if it is related with the URL bar performance issue reported on #11066.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.