Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Findbar slowness (cmd + F, typing) #10271

Closed
bsclifton opened this issue Aug 3, 2017 · 1 comment
Closed

Findbar slowness (cmd + F, typing) #10271

bsclifton opened this issue Aug 3, 2017 · 1 comment
Assignees
@bsclifton
Labels
hackathon Legacy label for a hackaton. perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.18.23 Hotfix

Comments

@bsclifton
Copy link
Member

bsclifton commented Aug 3, 2017 •
edited by luixxiul
Loading

Test plan

#10283 (comment)
@bsclifton bsclifton added hackathon Legacy label for a hackaton. perf labels Aug 3, 2017
@bsclifton bsclifton self-assigned this Aug 3, 2017
@bsclifton bsclifton mentioned this issue Aug 3, 2017
Closed
35 tasks
@bsclifton
Copy link
Member Author

bsclifton commented Aug 3, 2017 •
edited
Loading

I suspect this may happen when loading large pages. One example that I use is https://github.com/brave/browser-laptop/pull/7795/files

Here, you can expand the diff for npm-shrinkwrap.json

While that is loading (which takes a while), you can try to do the cmd/ctrl + f

@bsclifton bsclifton added this to the 0.18.x Hotfix milestone Aug 3, 2017
@bsclifton bsclifton mentioned this issue Aug 3, 2017
Merged
8 tasks
@bsclifton bsclifton modified the milestones: 0.20.x (Developer Channel), 0.18.x Hotfix Aug 3, 2017
This was referenced Aug 7, 2017
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 9, 2017
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Aug 16, 2017
Closed
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@bsclifton @dfperry5
Debounce keypresses to avoid wasted calls to windowStore when finding…
ca79cc8 
… on page

Should fix brave#10271

Auditors: @NejcZdovc
@bsclifton bsclifton mentioned this issue Aug 21, 2017
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
hackathon Legacy label for a hackaton. perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.23 Hotfix
Development

No branches or pull requests
4 participants
@luixxiul @bsclifton @srirambv @LaurenWags