Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update advancedSettings.js to the modified BEM style #10339

Closed
luixxiul opened this issue Aug 8, 2017 · 0 comments
Closed

Update advancedSettings.js to the modified BEM style #10339

luixxiul opened this issue Aug 8, 2017 · 0 comments
Assignees
@luixxiul
Labels
feature/about-pages polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 8, 2017 •
edited
Loading

Test plan

#10340 (comment)

Describe the issue you encountered: Update advancedSettings.js to the modified BEM style (ref: https://github.com/brave/browser-laptop/blob/master/docs/style.md#defining-our-blocks-elements-and-modifiers).

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Extra QA steps:

    1. Open about:preferences#payments
    2. Click the advanced setting icon
    3. Make sure the things are properly placed

  • Any related issues:
@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. refactoring/aphrodite labels Aug 8, 2017
@luixxiul luixxiul self-assigned this Aug 8, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 8, 2017
@luixxiul luixxiul mentioned this issue Aug 8, 2017
Merged
8 tasks
@bbondy bbondy removed this from the 0.21.x (Developer Channel) milestone Oct 25, 2017
@luixxiul luixxiul added this to the 0.20.x (Beta Channel) milestone Oct 28, 2017
This was referenced Dec 20, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/about-pages polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @kjozwiak @luixxiul @srirambv @LaurenWags