This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Update advancedSettings.js to the modified BEM style #10340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
added
feature/about-pages
polish
luixxiul
commented
Aug 8, 2017
| @@ -56,29 +56,30 @@ class AdvancedSettingsContent extends ImmutableComponent { | |||
| </SettingItem> | |||
| </SettingsList> | |||
| </div> | |||
| <div className={css(styles.settingsPanelDivider, styles.lastDivider)}> | |||
| <SettingsList className={css(commonStyles.noMarginBottom)} | |||
| listClassName={css(styles.list)} | |||
There was a problem hiding this comment.
we just don't need that
luixxiul
commented
Aug 8, 2017
| flexWrap: 'nowrap' | ||
| display: 'grid', | ||
| gridTemplateColumns: '1fr .75fr', | ||
| gridColumnGap: '32px' |
Codecov Report
@@ Coverage Diff @@
## master #10340 +/- ##
=======================================
Coverage 54.33% 54.33%
=======================================
Files 245 245
Lines 21156 21156
Branches 3260 3260
=======================================
Hits 11495 11495
Misses 9661 9661
|
Closes #10339 Also: - Replace flex with grid - aphrodite -> aphrodite/no-important Auditors: @cezaraugusto Test Plan: 1. Open about:preferences#payments 2. Enable Payments 3. Click the advanced setting icon 4. Make sure the things are properly placed
cezaraugusto
reviewed
Sep 4, 2017
| @@ -3,7 +3,7 @@ | |||
| * You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| const React = require('react') | |||
| const {StyleSheet, css} = require('aphrodite') | |||
| const {StyleSheet, css} = require('aphrodite/no-important') | |||
cezaraugusto
reviewed
Sep 4, 2017
| settingsPanelDivider: { | ||
| width: '100%' | ||
| display: 'grid', | ||
| gridTemplateColumns: '1fr .75fr', |
cezaraugusto
approved these changes
Sep 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10339
Also:
Test Plan:
Updated screenshot:
Old screenshot
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests