after close/reopen, pinned tab is duplicated as normal tab

[LaurenWags]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  After pinning a tab, closing/reopening Brave, my pinned tab is duplicated as a regular tab. Subsequent close/reopen of Brave results in another (regular) tab added each time for the pinned tab.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  MacOS

• Brave Version (revision SHA):
  Brave | 0.18.20
  rev | 60bb9e6
  Muon | 4.3.9

• Steps to reproduce:

  1. Start with a clean profile/install of 0.18.20.
  2. Open a new tab, visit a site.
  3. Open another new tab, visit a different site.
  4. Nav back to the site from step 2. Pin this tab.
  5. Close/Reopen Brave.
  6. Pinned site remains, but it also displays as a regular tab.

• Actual result:
  Pinned tab displays as pinned tab and regular tab. Additionally, if you continue to close/reopen Brave each time a new (regular) tab will be added with the site from the pinned tab.

• Expected result:
  No duplicate tabs should be opened, just the pinned tab.

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  no

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  

• Any related issues:
  Possibly pinned tabs either missing or duplicated after Brave relaunch #10179

[bsclifton]

I confirmed this is caused by cccb3dd

Looking into a fix...

[luixxiul]

I noticed a similar issue, where you get duplicate pinned tabs when you open a link in a new tab. Is this also caused by the same commit?

[bbondy]

master: e3e2855
0.20.x: c5c3787
0.19.x: beac410
0.18.x: 3f21513