Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

replace node classList instances with dataset #10443

Closed
cezaraugusto opened this issue Aug 11, 2017 · 1 comment · Fixed by #10445
Closed

replace node classList instances with dataset #10443

cezaraugusto opened this issue Aug 11, 2017 · 1 comment · Fixed by #10445
Assignees
@cezaraugusto
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Aug 11, 2017 •
edited by luixxiul
Loading

Test plan

#10445 (comment)

This unblocks #10234
@cezaraugusto cezaraugusto added this to the 0.21.x (Nightly Channel) milestone Aug 11, 2017
@cezaraugusto cezaraugusto self-assigned this Aug 11, 2017
cezaraugusto added a commit that referenced this issue Aug 11, 2017
@cezaraugusto
replace classList with dataset for bookmarksOverflowIndicator
d5a6317 
Address #10443
Auditors: @luixxiul, @bsclifton
cezaraugusto added a commit that referenced this issue Aug 11, 2017
@cezaraugusto
replace classList with dataset for bookmarksOverflowIndicator
fce5ebf 
Fix #10443
Auditors: @luixxiul, @bsclifton
cezaraugusto added a commit that referenced this issue Aug 11, 2017
@cezaraugusto
replace classList with dataset for bookmarksOverflowIndicator
87dd2ee 
Fix #10443
Auditors: @luixxiul, @bsclifton
cezaraugusto added a commit that referenced this issue Aug 11, 2017
@cezaraugusto
replace classList with dataset for contextMenu
331a29b 
Fix #10443
Auditors: @luixxiul, @bsclifton
@cezaraugusto cezaraugusto mentioned this issue Aug 11, 2017
Merged
cezaraugusto added a commit that referenced this issue Aug 11, 2017
@cezaraugusto
replace classList with dataset for contextMenu
6191c99 
Fix #10443
Auditors: @luixxiul, @NejcZdovc
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@cezaraugusto @dfperry5
replace classList with dataset for bookmarksOverflowIndicator
96e8d75 
Address brave#10443
Auditors: @luixxiul, @bsclifton
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@cezaraugusto @dfperry5
replace classList with dataset for contextMenu
768db82 
Fix brave#10443
Auditors: @luixxiul, @NejcZdovc
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@srirambv
Copy link
Collaborator

Needs to be retested based on #10445 (comment). Removing Linux check label

This was referenced Dec 27, 2017
Closed
Closed
Closed
This was referenced Jan 2, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jan 9, 2018
Closed
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

replace node classList with dataset brave/browser-laptop
5 participants
@bbondy @luixxiul @cezaraugusto @srirambv @LaurenWags