Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave prompts to create new keychain named "Default Keychain" #10448

Closed
evq opened this issue Aug 12, 2017 · 4 comments
Closed

Brave prompts to create new keychain named "Default Keychain" #10448

evq opened this issue Aug 12, 2017 · 4 comments
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. stale

Comments

@evq
Copy link
Member

evq commented Aug 12, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:

With the recent muon change to encrypt cookie data at rest, Brave now has a hard dependency on gnome-keyring on linux (before it was only needed if you opted to use the builtin password manager). As a result, if you do not already have a keychain, Brave will prompt you to create a new one. I cannot confirm, but I would imagine that if there is an existing keychain, the user would be prompted to allow access. If possible we should use a keychain name that better indicates why Brave is asking for keychain access.

Furthermore, despite being used to protect user data - having to allow keychain access will be seen by some users as concerning. Some users will want a way to stop all requests for keychain access.

See a similar discussion about Chrome asking for access:
https://productforums.google.com/forum/#!topic/chrome/BPLVDSeTmgI

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Linux

  • Brave Version (revision SHA):
    0.19.2

  • Screenshot if needed:
    keychain

@bsclifton
Copy link
Member

cc: @darkdh

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Aug 13, 2017
@darkdh
Copy link
Member

darkdh commented Aug 16, 2017

libgnome-keyring is almost deprecated by libsecret
https://bugs.chromium.org/p/chromium/issues/detail?id=466975

@luixxiul
Copy link
Contributor

luixxiul commented Sep 9, 2017

Is it OK to close this?

@darkdh
Copy link
Member

darkdh commented Sep 13, 2017

need investigation, I will check with @evq

@luixxiul luixxiul added needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. and removed needs-info Another team member needs information from the PR/issue opener. labels Sep 13, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton added stale addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Sep 9, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. stale
Projects
None yet
Development

No branches or pull requests

4 participants