Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove keytar and gnome-keyring deps #10514

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Remove keytar and gnome-keyring deps #10514

merged 1 commit into from
Aug 17, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Aug 15, 2017

Give up on migrating old passwords for users who are updating from <0.15.300 to 0.21 and above.

Fix #10226

Test Plan:
npm run test -- --grep='passwords'

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@diracdeltas diracdeltas added this to the 0.21.x (Nightly Channel) milestone Aug 15, 2017
@diracdeltas diracdeltas self-assigned this Aug 15, 2017
@diracdeltas diracdeltas requested review from posix4e and darkdh August 15, 2017 21:51
@posix4e
Copy link
Contributor

posix4e commented Aug 16, 2017

This will make 32 bit builds on linux way easier as well. keytar is the last real dep that needs weird pkg_config options when doing the 32 bit linux build. Perfect timing.

Copy link
Contributor

@posix4e posix4e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume this is possible due to the new sync library.

const passwordManagerReducer = (state, action, immutableAction) => {
action = immutableAction || makeImmutable(action)
switch (action.get('actionType')) {
case appConstants.APP_SET_STATE:
init()
state = migrate(state)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also check if legacyPasswords exists or not. If so, we should delete it to prevent our session data from getting bloated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@luixxiul luixxiul mentioned this pull request Aug 16, 2017
@@ -37,4 +37,3 @@ addons:
packages:
- xvfb
- g++-4.8
- libgnome-keyring-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnome-keyring is needed at runtime by muon, not sure if removing this will cause issues.
see: #10448

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnome-keyring is deprecated by libsecret

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think this is the deps for keytar use not for muon which will be precompiled before browser-laptop can use it.

Give up on migrating old passwords for users who are updating from <0.15.300 to 0.21 and above.

Fix #10226

Test Plan:
npm run test -- --grep='passwords'
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@diracdeltas diracdeltas merged commit 00c0692 into master Aug 17, 2017
@diracdeltas diracdeltas deleted the fix/remove-keytar branch August 17, 2017 22:50
@NejcZdovc NejcZdovc mentioned this pull request Aug 18, 2017
8 tasks
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants