Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove keytar dependency #10226

Closed
luixxiul opened this issue Aug 1, 2017 · 1 comment
Closed

Remove keytar dependency #10226

luixxiul opened this issue Aug 1, 2017 · 1 comment

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 1, 2017

Test plan

Make sure the install instruction on a fresh environment works:
https://github.com/brave/browser-laptop#on-debian--ubuntu-mint
https://github.com/brave/browser-laptop#on-fedora


Describe the issue you encountered:

Remove keytar dependency. See: #10227 (comment)

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 1, 2017
@luixxiul luixxiul modified the milestones: 0.22.x, 0.21.x (Nightly Channel) Aug 1, 2017
@luixxiul luixxiul changed the title Update keytar to 4.0.4 Remove keytar dependency Aug 2, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 2, 2017

Renamed the title based on the discussion here: #10227 (comment)

@luixxiul luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.22.x Aug 2, 2017
diracdeltas added a commit that referenced this issue Aug 15, 2017
Give up on migrating old passwords for users who are updating from <0.15.300 to 0.21 and above.

Fix #10226

Test Plan:
npm run test -- --grep='passwords'
diracdeltas added a commit that referenced this issue Aug 16, 2017
Give up on migrating old passwords for users who are updating from <0.15.300 to 0.21 and above.

Fix #10226

Test Plan:
npm run test -- --grep='passwords'
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.