Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Green tick on payments icon disappears by moving to sub level of the verified site #10484

Closed
luixxiul opened this issue Aug 15, 2017 · 7 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 15, 2017

Test Plan

See Steps to Reproduce and #10484 (comment)

Describe the issue you encountered:
The green tick on payments icon disappears by moving to sub level of the verified site. Is this intended?

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): 0.18.22

  • Steps to reproduce:

    1. Open https://brianbondy.com
    2. Click "Filters"
  • Actual result: the green tick on the payments icon disappears

  • Expected result: ?

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul luixxiul added design A design change, especially one which needs input from the design team. question labels Aug 15, 2017
@luixxiul
Copy link
Contributor Author

CC @bradleyrichter

@alexwykoff
Copy link
Contributor

"If it qualifies as a part a verified domain, it should have the mark" - @bradleyrichter

@bsclifton bsclifton added priority/P4 Minor loss of function. Workaround usually present. initiative/bat-payments and removed priority/high (deprecated) design A design change, especially one which needs input from the design team. labels Nov 22, 2017
@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Nov 22, 2017
@jasonrsadler
Copy link
Contributor

@luixxiul , Do you have any more example urls that didn't show verified at sub levels?

@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), Completed work Apr 6, 2018
@NejcZdovc NejcZdovc modified the milestones: Completed work, 0.22.x Release 2, 0.22.x Release 3 (Beta channel) Apr 10, 2018
NejcZdovc added a commit that referenced this issue Apr 20, 2018
Some verified publishers no longer remove green tick at sublevels - Fixes issue #10484
NejcZdovc added a commit that referenced this issue Apr 20, 2018
Some verified publishers no longer remove green tick at sublevels - Fixes issue #10484
NejcZdovc added a commit that referenced this issue Apr 20, 2018
Some verified publishers no longer remove green tick at sublevels - Fixes issue #10484
@LaurenWags
Copy link
Member

@jasonrsadler are the STR in this issue sufficient for a Test Plan or are there other steps QA should go through?

@jasonrsadler
Copy link
Contributor

jasonrsadler commented Apr 23, 2018

The STR should be sufficient. I would test out with other known verified sites as well.

The brianbondy site was the only site I could reproduce the issue with (that site either preloads on enter or uses historyAPI that doesn't do a full POST or GET)

@LaurenWags
Copy link
Member

Thanks @jasonrsadler 😄

@srirambv
Copy link
Collaborator

srirambv commented May 3, 2018

Verified on Windows x64

  • 0.22.702 e4a853d
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.7

Verified with macOS 10.12.6 using

  • 0.22.702 e4a853d
  • muon 6.0.7
  • libchromiumcontent 66.0.3359.139

Verified on Ubuntu 17.10 x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.